Page MenuHomePhabricator
Differential D5639

[services] Tunnelbroker - Expose config to the Rust
ClosedPublic
Actions

Authored by • max on Nov 16 2022, 3:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 1, 1:16 AM
Unknown Object (File)
Sun, Jun 30, 5:46 PM
Unknown Object (File)
Tue, Jun 18, 6:44 AM
Unknown Object (File)
Mon, Jun 17, 5:14 AM
Unknown Object (File)
Mon, Jun 17, 5:13 AM
Unknown Object (File)
Tue, Jun 4, 8:08 PM
Unknown Object (File)
Mon, Jun 3, 8:34 AM
Unknown Object (File)
May 26 2024, 6:19 AM
View All 61 Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
• jon
varun
Commits
rCOMMf863b716e483: [services] Tunnelbroker - Expose config to the Rust
Summary

In this diff, we are exposing a function to get the parameter from the config file from the C++ codebase to the Rust codebase as a getConfigParameter function.
This function will be used in the Rust codebase diff D5641 and forward.

Linear task: ENG-1893

Test Plan
  1. Service is successfully built.
  2. The diff D5641 where the function is used the service is successfully built.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Nov 16 2022, 3:17 AM
• max held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptNov 16 2022, 3:17 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
• max added a child revision: D5640: [services] Tunnelbroker - Expose `isSandbox` to the Rust.Nov 16 2022, 3:19 AM
Harbormaster failed remote builds in B13459: Diff 18458!Nov 16 2022, 3:19 AM
• max edited the summary of this revision. (Show Details)Nov 16 2022, 4:42 AM
• max edited the test plan for this revision. (Show Details)
• max added a reviewer: tomek.
• max edited the summary of this revision. (Show Details)
• max edited reviewers, added: varun; removed: tomek. • max added 1 blocking reviewer(s): • jon.
Harbormaster completed remote builds in B13459: Diff 18458.Nov 16 2022, 4:44 AM
• max published this revision for review.Nov 16 2022, 4:44 AM
• jon accepted this revision.Nov 16 2022, 2:56 PM

okay with this as a transition away from C++

This revision is now accepted and ready to land.Nov 16 2022, 2:56 PM
Closed by commit rCOMMf863b716e483: [services] Tunnelbroker - Expose config to the Rust (authored by • max). · Explain WhyNov 19 2022, 4:04 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMMf863b716e483: [services] Tunnelbroker - Expose config to the Rust.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
1 line
libcpp/
1 line
6 lines

Diff 18610

View Options

services/tunnelbroker/src/cxx_bridge.rs

Loading...
View Options

services/tunnelbroker/src/libcpp/Tunnelbroker.h

Loading...
View Options

services/tunnelbroker/src/libcpp/Tunnelbroker.cpp

Loading...