[services] Tunnelbroker - Expose `isSandbox` to the Rust
ClosedPublic
Actions

Authored by • max on Nov 16 2022, 3:18 AM.

Details

Reviewers

• jon
varun
marcin

Commits

rCOMMdc959d543158: [services] Tunnelbroker - Expose `isSandbox` to the Rust

Summary

In this diff, we are exposing a function to get if the server is running a sandbox mode from the C++ codebase to the Rust codebase as a isSandbox function.
This function will be used in the Rust codebase diff D5641 and forward.

Linear task: ENG-1893

Test Plan

Service is successfully built.
The diff D5641 where the function is used the service is successfully built.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Nov 16 2022, 3:18 AM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptNov 16 2022, 3:18 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• max added a parent revision: D5639: [services] Tunnelbroker - Expose config to the Rust.Nov 16 2022, 3:19 AM

• max added a child revision: D5641: [services] Tunnelbroker - Notifications config initialization.Nov 16 2022, 3:21 AM

Harbormaster completed remote builds in B13460: Diff 18459.Nov 16 2022, 3:31 AM

• max published this revision for review.Nov 16 2022, 4:45 AM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: varun, marcin. • max added 1 blocking reviewer(s): • jon.

I would like to see configuration done in rust, as argument reading + argument validation is a bit nicer using crates like clap. But as a transition, I think this is fine.

From an architectural standpoint, I don't think the business logic should really be aware of whether it's running in a sandbox. We should be passing it other values (e.g. dev rabbitmq endpoints) which make the environment a sandbox.

This revision is now accepted and ready to land.Nov 16 2022, 2:50 PM

• jon mentioned this in D5641: [services] Tunnelbroker - Notifications config initialization.Nov 16 2022, 2:51 PM

• jon mentioned this in D5642: [services] Tunnelbroker - Updating notifications libraries with the config.Nov 16 2022, 2:56 PM

In D5640#167758, @jon wrote:

I would like to see configuration done in rust, as argument reading + argument validation is a bit nicer using crates like clap. But as a transition, I think this is fine.

From an architectural standpoint, I don't think the business logic should really be aware of whether it's running in a sandbox. We should be passing it other values (e.g. dev rabbitmq endpoints) which make the environment a sandbox.

Yeah, I agree with that. I've created a follow-up task for this.

Closed by commit rCOMMdc959d543158: [services] Tunnelbroker - Expose `isSandbox` to the Rust (authored by • max). · Explain WhyNov 19 2022, 4:11 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMMdc959d543158: [services] Tunnelbroker - Expose `isSandbox` to the Rust.