Page MenuHomePhabricator

[services] Tunnelbroker - Notifications config initialization
ClosedPublic

Authored by max on Nov 16 2022, 3:20 AM.
Tags
None
Referenced Files
F3515951: D5641.diff
Sun, Dec 22, 11:16 AM
Unknown Object (File)
Mon, Nov 25, 5:47 PM
Unknown Object (File)
Sun, Nov 24, 11:52 AM
Unknown Object (File)
Sun, Nov 24, 11:52 AM
Unknown Object (File)
Sun, Nov 24, 11:52 AM
Unknown Object (File)
Oct 25 2024, 5:18 PM
Unknown Object (File)
Oct 25 2024, 5:18 PM
Unknown Object (File)
Oct 25 2024, 5:17 PM

Details

Summary

In this diff, we initialize the static configuration as a struct for the internal notifications library to avoid passing repeated parameters on every notification-sending call. We are using a lazy static initialization and parameters from the Tunnelbroker's configuration file.
This diff is related to the abandoned D5329. The static configuration is used in the D5642 diff updates.

Linear task: ENG-1737

Test Plan
  1. Service is successfully built.
  2. The diff D5641 where the function is used the service is successfully built.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

max held this revision as a draft.
max edited the test plan for this revision. (Show Details)
max added reviewers: tomek, varun.
max published this revision for review.Nov 16 2022, 5:35 AM

Adding @tomek here as this diff is a follow-up from the abandoned D5329 and D5330 that are passed the first pass.

I'm okay with this for now. https://phab.comm.dev/D5640#167758 Applies to this as well, but this looks to be moving in the right direction.

This revision is now accepted and ready to land.Nov 17 2022, 3:32 AM