[web] Calling utility functions in Overlay component.
ClosedPublic
Actions

Authored by • przemek on Nov 24 2022, 7:27 AM.

Details

Reviewers

tomek
atul
kamil

Commits

rCOMMa20f02f5e88f: [web] Calling utility functions in Overlay component.

Summary

The component now takes all the data needed via props and calls utility functions wrapped in useMemo.
Moved type exports to utility file in previous diff.

Test Plan

Component not rendered yet, but tested visibility.
App builds.

Diff Detail

Repository

rCOMM Comm

Branch

feat/mention

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• przemek created this revision.Nov 24 2022, 7:27 AM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 24 2022, 7:27 AM

Harbormaster completed remote builds in B13736: Diff 18819.Nov 24 2022, 7:40 AM

• przemek requested review of this revision.Nov 24 2022, 7:40 AM

• przemek added a parent revision: D5719: [web] Added more utility functions for typeahead..Nov 24 2022, 7:42 AM

• przemek added 1 blocking reviewer(s): tomek.

• przemek added a child revision: D5722: [web] Creating typeahead overlay in ChatInputbar.Nov 24 2022, 8:21 AM

tomek requested changes to this revision.Nov 25 2022, 3:19 AM

tomek added inline comments.

web/chat/mention-suggestion-tooltip.react.js
24	This isn't too useful for the component. It's hard to deduce what's inside of it without checking all the usages. It's more maintainable to simply pass the strings instead.

This revision now requires changes to proceed.Nov 25 2022, 3:19 AM

• przemek marked an inline comment as done.Nov 25 2022, 8:10 AM

• przemek added inline comments.