Page MenuHomePhabricator
Differential D5739

[keyserver] APIs for finishing client side of PAKE login
ClosedPublic
Actions

Authored by varun on Nov 28 2022, 7:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 7, 1:56 PM
Unknown Object (File)
Mar 7 2025, 9:11 PM
Unknown Object (File)
Mar 3 2025, 4:03 AM
Unknown Object (File)
Mar 3 2025, 3:54 AM
Unknown Object (File)
Feb 27 2025, 11:41 AM
Unknown Object (File)
Feb 13 2025, 9:15 AM
Unknown Object (File)
Feb 1 2025, 3:42 AM
Unknown Object (File)
Jan 30 2025, 9:25 PM
View All Files
Subscribers
ashoat
bartek

Details

Reviewers
tomek
• jon
bartek
Commits
rCOMMcee46d8c4a98: [keyserver] APIs for finishing client side of PAKE login
Summary

using Neon to surface the Rust opaque-ke "client login finish" API and getters to Node.js

Test Plan

called the new APIs from a Node module and confirmed the results

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Nov 28 2022, 7:51 AM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 28 2022, 7:51 AM
varun added a parent revision: D5738: [keyserver] APIs for starting client side of PAKE login.Nov 28 2022, 7:57 AM
Harbormaster completed remote builds in B13791: Diff 18882.Nov 28 2022, 8:05 AM
varun requested review of this revision.Nov 28 2022, 8:05 AM
atul added a reviewer: bartek.Nov 28 2022, 2:53 PM
atul added a subscriber: bartek.

(Think it probably makes sense to add @bartek to your Rust diffs even if he doesn't have full context on identity stuff? CC @ashoat @tomek who probably have a better idea)

atul resigned from this revision.Nov 28 2022, 3:52 PM

Don't have context + enough rust knowledge here

tomek added inline comments.Nov 29 2022, 7:28 AM
keyserver/addons/opaque-ke-node/src/lib.rs
212–216 ↗(On Diff #18882)

Please avoid using shadowing

varun updated this revision to Diff 18995.Nov 29 2022, 11:33 PM

change variable names to avoid shadowing, change js functions to camelCase

varun edited reviewers, added: Restricted Owners Package; removed: tomek, atul, bartek.Nov 29 2022, 11:34 PM
Harbormaster failed remote builds in B13871: Diff 18995!Nov 29 2022, 11:34 PM
varun edited reviewers, added: tomek, • jon, bartek; removed: Restricted Owners Package.Nov 29 2022, 11:34 PM
varun updated this revision to Diff 19000.Nov 29 2022, 11:49 PM

rebase

Harbormaster completed remote builds in B13876: Diff 19000.Nov 30 2022, 12:01 AM
tomek accepted this revision.Nov 30 2022, 5:33 AM
bartek accepted this revision.Nov 30 2022, 6:04 AM
• jon accepted this revision.Nov 30 2022, 11:44 AM
This revision is now accepted and ready to land.Nov 30 2022, 11:44 AM
Closed by commit rCOMMcee46d8c4a98: [keyserver] APIs for finishing client side of PAKE login (authored by varun). · Explain WhyNov 30 2022, 1:04 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMcee46d8c4a98: [keyserver] APIs for finishing client side of PAKE login.

Revision Contents
Changeset List

PathSize
keyserver/
addons/
opaque-ke-node/
src/
64 lines

Diff 18995

View Options

keyserver/addons/opaque-ke-node/src/lib.rs

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
jsi::Value getUserPublicKey(jsi::Runtime &rt) override; jsi::Value getUserPublicKey(jsi::Runtime &rt) override;
jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override; jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;
jsi::Object jsi::Object
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
void clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm