Page MenuHomePhabricator
Differential D5755

[native] Add markdownASTHasPressable to TextMessageMarkdownContext
ClosedPublic
Actions

Authored by ashoat on Nov 29 2022, 7:21 AM.
Tags
None
Referenced Files
F3542843: D5755.id18960.diff
Thu, Dec 26, 9:11 AM
Unknown Object (File)
Sun, Dec 1, 11:05 PM
Unknown Object (File)
Wed, Nov 27, 10:05 PM
Unknown Object (File)
Wed, Nov 27, 6:48 AM
Unknown Object (File)
Nov 23 2024, 2:38 PM
Unknown Object (File)
Nov 8 2024, 4:16 PM
Unknown Object (File)
Nov 8 2024, 4:16 PM
Unknown Object (File)
Nov 8 2024, 4:08 PM
View All Files
Subscribers
tomek

Details

Reviewers
rohan
atul
ginsu
michal
Commits
rCOMMea3296304fe2: [native] Add markdownASTHasPressable to TextMessageMarkdownContext
Summary

We need to know whether the Markdown has any pressables because we're going to render it differently in that case.

Test Plan

I tested the following text and made sure each link counted as pressable:

Here’s a [link](https://comm.app)

Here’s a **bold [link2](https://comm.app)**

here’s a [**bold link3**](https://comm.app)

Here’s a raw link https://comm.app

Here’s a **bolded raw link https://comm.app**

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 29 2022, 7:21 AM
Herald added a subscriber: tomek. · View Herald TranscriptNov 29 2022, 7:21 AM
ashoat added a parent revision: D5754: [native] Introduce TextMessageMarkdownContext.Nov 29 2022, 7:21 AM
ashoat added a reviewer: michal.Nov 29 2022, 7:25 AM
Harbormaster completed remote builds in B13842: Diff 18960.Nov 29 2022, 7:34 AM
ashoat requested review of this revision.Nov 29 2022, 7:34 AM
ashoat mentioned this in D5715: [lib] Prevent spoiler text from appearing in MessagePreview.Nov 29 2022, 3:47 PM
ashoat added a child revision: D5763: [native] Pass TextMessage.onPress down via context.Nov 29 2022, 8:13 PM
atul accepted this revision.Nov 30 2022, 9:19 AM

(Scenarios included in the Test Plan seem like they'd be good candidates for unit tests... just a thought definitely not a priority)

This revision is now accepted and ready to land.Nov 30 2022, 9:19 AM
rohan accepted this revision.Nov 30 2022, 9:23 AM
Closed by commit rCOMMea3296304fe2: [native] Add markdownASTHasPressable to TextMessageMarkdownContext (authored by ashoat). · Explain WhyNov 30 2022, 11:10 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMea3296304fe2: [native] Add markdownASTHasPressable to TextMessageMarkdownContext.

Revision Contents
Changeset List

PathSize
native/
chat/
19 lines

Diff 19023

View Options

native/chat/text-message-markdown-context.js

Loading...