Page MenuHomePhabricator

[native] Add markdownASTHasPressable to TextMessageMarkdownContext
ClosedPublic

Authored by ashoat on Nov 29 2022, 7:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 10:08 PM
Unknown Object (File)
Thu, May 2, 10:08 PM
Unknown Object (File)
Thu, May 2, 10:05 PM
Unknown Object (File)
Thu, May 2, 8:23 PM
Unknown Object (File)
Mar 31 2024, 7:06 AM
Unknown Object (File)
Mar 31 2024, 7:05 AM
Unknown Object (File)
Mar 31 2024, 7:05 AM
Unknown Object (File)
Mar 31 2024, 7:02 AM
Subscribers

Details

Summary

We need to know whether the Markdown has any pressables because we're going to render it differently in that case.

Test Plan

I tested the following text and made sure each link counted as pressable:

Here’s a [link](https://comm.app)

Here’s a **bold [link2](https://comm.app)**

here’s a [**bold link3**](https://comm.app)

Here’s a raw link https://comm.app

Here’s a **bolded raw link https://comm.app**

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

(Scenarios included in the Test Plan seem like they'd be good candidates for unit tests... just a thought definitely not a priority)

This revision is now accepted and ready to land.Nov 30 2022, 9:19 AM