[native] Move useTextMessageMarkdownRules to message-list-types.js
ClosedPublic
Actions

Authored by ashoat on Nov 29 2022, 7:19 AM.

Details

Reviewers

rohan
atul
ginsu
michal

Commits

rCOMM6dd336abfbb6: [native] Move useTextMessageMarkdownRules to message-list-types.js

Summary

I want to use this function in another place, so we can generate and cache the Markdown AST upstream of InnerTextMessage in order to determine whether the Markdown includes a "pressable" (link or spoiler for now, but @mention in the future).

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 29 2022, 7:19 AM

Herald added a subscriber: tomek. · View Herald TranscriptNov 29 2022, 7:19 AM

ashoat added a child revision: D5754: [native] Introduce TextMessageMarkdownContext.Nov 29 2022, 7:22 AM

ashoat added a reviewer: michal.Nov 29 2022, 7:25 AM

Harbormaster completed remote builds in B13840: Diff 18958.Nov 29 2022, 7:32 AM

ashoat requested review of this revision.Nov 29 2022, 7:32 AM

Looks good - checked it out locally, the behavior is still as expected, and the function isn't called in any other places

This revision is now accepted and ready to land.Nov 30 2022, 9:10 AM

Closed by commit rCOMM6dd336abfbb6: [native] Move useTextMessageMarkdownRules to message-list-types.js (authored by ashoat). · Explain WhyNov 30 2022, 11:10 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6dd336abfbb6: [native] Move useTextMessageMarkdownRules to message-list-types.js.

Revision Contents
Changeset List

Path

Size

native/

chat/

inner-text-message.react.js

9 lines

message-list-types.js

9 lines

Diff 19021

View Options

native/chat/inner-text-message.react.js

// @flow		// @flow

		import invariant from 'invariant';
import * as React from 'react';		import * as React from 'react';

import {		import {
sendReactionMessage,		sendReactionMessage,
sendReactionMessageActionTypes,		sendReactionMessageActionTypes,
} from 'lib/actions/message-actions';		} from 'lib/actions/message-actions';
import { useModalContext } from 'lib/components/modal-provider.react';		import { useModalContext } from 'lib/components/modal-provider.react';
		import { messageTypes } from 'lib/types/message-types';
		import type { RawReactionMessageInfo } from 'lib/types/messages/reaction';
import {		import {
useDispatchActionPromise,		useDispatchActionPromise,
useServerCall,		useServerCall,
} from 'lib/utils/action-utils';		} from 'lib/utils/action-utils';

import Alert from '../modals/alert.react';		import Alert from '../modals/alert.react';
		import { useSelector } from '../redux/redux-utils';

function useOnClickReact(		function useOnClickReact(
messageID: ?string,		messageID: ?string,
localID: string,		localID: string,
threadID: string,		threadID: string,
reaction: string,		reaction: string,
action: 'add_reaction' \| 'remove_reaction',		action: 'add_reaction' \| 'remove_reaction',
): (event: SyntheticEvent<HTMLElement>) => mixed {		): (event: SyntheticEvent<HTMLElement>) => mixed {
const { pushModal } = useModalContext();		const { pushModal } = useModalContext();

		const viewerID = useSelector(
		state => state.currentUserInfo && state.currentUserInfo.id,
		);

const callSendReactionMessage = useServerCall(sendReactionMessage);		const callSendReactionMessage = useServerCall(sendReactionMessage);
const dispatchActionPromise = useDispatchActionPromise();		const dispatchActionPromise = useDispatchActionPromise();

return React.useCallback(		return React.useCallback(
(event: SyntheticEvent<HTMLElement>) => {		(event: SyntheticEvent<HTMLElement>) => {
event.preventDefault();		event.preventDefault();

if (!messageID) {		if (!messageID) {
return;		return;
}		}

		invariant(viewerID, 'viewerID should be set');

const reactionMessagePromise = (async () => {		const reactionMessagePromise = (async () => {
try {		try {
const result = await callSendReactionMessage({		const result = await callSendReactionMessage({
threadID,		threadID,
localID,		localID,
targetMessageID: messageID,		targetMessageID: messageID,
reaction,		reaction,
action,		action,
Show All 9 Lines	(event: SyntheticEvent<HTMLElement>) => {
<Alert title="Couldn’t send the reaction">		<Alert title="Couldn’t send the reaction">
Please try again later		Please try again later
</Alert>,		</Alert>,
);		);
throw e;		throw e;
}		}
})();		})();

		const startingPayload: RawReactionMessageInfo = {
		type: messageTypes.REACTION,
		threadID,
		localID,
		creatorID: viewerID,
		time: Date.now(),
		targetMessageID: messageID,
		reaction,
		action,
		};

dispatchActionPromise(		dispatchActionPromise(
sendReactionMessageActionTypes,		sendReactionMessageActionTypes,
reactionMessagePromise,		reactionMessagePromise,
		undefined,
		startingPayload,
);		);
},		},
[		[
action,
callSendReactionMessage,
dispatchActionPromise,
messageID,		messageID,
pushModal,
reaction,
threadID,		threadID,
localID,		localID,
		viewerID,
		reaction,
		action,
		dispatchActionPromise,
		callSendReactionMessage,
		pushModal,
],		],
);		);
}		}

export { useOnClickReact };		export { useOnClickReact };