[native] Move useTextMessageMarkdownRules to message-list-types.js
ClosedPublic
Actions

Authored by ashoat on Nov 29 2022, 7:19 AM.

Details

Reviewers

rohan
atul
ginsu
michal

Commits

rCOMM6dd336abfbb6: [native] Move useTextMessageMarkdownRules to message-list-types.js

Summary

I want to use this function in another place, so we can generate and cache the Markdown AST upstream of InnerTextMessage in order to determine whether the Markdown includes a "pressable" (link or spoiler for now, but @mention in the future).

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 29 2022, 7:19 AM

Herald added a subscriber: tomek. · View Herald TranscriptNov 29 2022, 7:19 AM

ashoat added a child revision: D5754: [native] Introduce TextMessageMarkdownContext.Nov 29 2022, 7:22 AM

ashoat added a reviewer: michal.Nov 29 2022, 7:25 AM

Harbormaster completed remote builds in B13840: Diff 18958.Nov 29 2022, 7:32 AM

ashoat requested review of this revision.Nov 29 2022, 7:32 AM

Looks good - checked it out locally, the behavior is still as expected, and the function isn't called in any other places

This revision is now accepted and ready to land.Nov 30 2022, 9:10 AM

Closed by commit rCOMM6dd336abfbb6: [native] Move useTextMessageMarkdownRules to message-list-types.js (authored by ashoat). · Explain WhyNov 30 2022, 11:10 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6dd336abfbb6: [native] Move useTextMessageMarkdownRules to message-list-types.js.

Revision Contents
Changeset List

Path

Size

native/

chat/

inner-text-message.react.js

9 lines

message-list-types.js

9 lines

Diff 18958

View Options

native/chat/inner-text-message.react.js