Page MenuHomePhabricator
Differential D5809

[services] Tunnelbroker - Removing rudimental `ping` message from the protobuf
ClosedPublic
Actions

Authored by • max on Dec 5 2022, 6:17 AM.
Tags
None
Referenced Files
F2153653: D5809.diff
Sun, Jun 30, 5:43 PM
Unknown Object (File)
Tue, Jun 25, 12:22 AM
Unknown Object (File)
Fri, Jun 21, 8:41 PM
Unknown Object (File)
Fri, Jun 21, 8:41 PM
Unknown Object (File)
Mon, Jun 17, 10:57 PM
Unknown Object (File)
Mon, Jun 17, 10:49 PM
Unknown Object (File)
Mon, Jun 17, 10:49 PM
Unknown Object (File)
May 29 2024, 9:50 PM
View All 74 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
tomek
ashoat
Commits
rCOMMa3a50255a4ce: [services] Tunnelbroker - Removing rudimental `ping` message from the protobuf
Summary

This diff removes the rudimental ping message from the protobuf.

The "pinging" message mechanism was changed to the gRPC keep-alive mechanism and the server implementation was changed in D5713. The empty "ping" message should be removed from the protobuf API as it's not used anymore.

Linear task: ENG-2405

Test Plan
  1. Services are successfully built.
  2. CI tests passed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
shared/
protos/
_generated/
1 line

Diff 19186

View Options

shared/protos/_generated/tunnelbroker.pb.h

Loading...
View Options

shared/protos/_generated/tunnelbroker.pb.cc

Loading...
View Options

shared/protos/tunnelbroker.proto

Loading...