[lib] client side logic for handling policy acknowledgment
ClosedPublic
Actions

Authored by kamil on Dec 6 2022, 6:21 AM.

Details

Reviewers

tomek
atul

Commits

rCOMM685c6e10f284: [lib] client side logic for handling policy acknowledgment

Summary

Adding a redux store in which will be stored data about user's policies, and action which will be dispatched on acknowledgment.

Context in ENG-2363.

There is a minor thing with this approach, there is possibility to dispatch the action multiple times, more in ENG-2431.

Test Plan

Connect to keyserver from account without accepted policies and check if action was properly dispatched after interaction with keyserver on both mobile/web.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Dec 6 2022, 6:21 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptDec 6 2022, 6:21 AM

kamil edited the summary of this revision. (Show Details)Dec 6 2022, 6:23 AM

kamil added a parent revision: D5824: [keyserver] validate if policies are acknowledged on request.

kamil added a child revision: D5827: [lib] handle `policies_not_accepted` error on client.Dec 6 2022, 6:27 AM

Harbormaster completed remote builds in B14006: Diff 19179.Dec 6 2022, 6:32 AM

kamil published this revision for review.Dec 6 2022, 6:55 AM

kamil edited the summary of this revision. (Show Details)Dec 8 2022, 1:46 AM

tomek requested changes to this revision.Dec 8 2022, 8:22 AM

tomek added inline comments.

lib/actions/user-actions.js
235–237	Shouldn't we return a result from this function?
lib/reducers/policies-reducer.js
5–6	We can merge these
lib/types/policy-types.js
5–24	Shouldn't all of these be readonly?
lib/types/redux-types.js
52–56	We can merge these

This revision now requires changes to proceed.Dec 8 2022, 8:22 AM

merge imports, make fields read-only

kamil added inline comments.Dec 13 2022, 5:45 AM

lib/actions/user-actions.js
235–237	keyserver returns void, so we do not return here anything but to update policy in redux we use a value from this part of code: D5828 - which is returning after successful call to keyserver