In policy acknowledging logic we need to track whether modal is visible or not. As suggested in https://phab.comm.dev/D5830#inline-39308 we want to avoid duplicated state and what is more important have single source of truth. We need to have the modal key and then we will be able to check if given modal is present in modals array or no.
Details
Details
- Reviewers
tomek - Commits
- rCOMM27d7d118b3db: [web] refactor modal API to return modal key
This code does not affect logic, but worth checking if modals on website works properly
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- policy-stuff-5
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
lib/components/modal-provider.react.js | ||
---|---|---|
13 | We can define React.Node => string as a separate type and use in all the places where pushModal is used |