[web] Refactor and renaming of typeahead utils.
AbandonedPublic
Actions

Authored by • przemek on Dec 15 2022, 4:11 AM.

Details

Reviewers

kamil
ginsu
inka
tomek

Summary

Renamed some arguments.
Moved one function to lib, so it can be reused in native counterpart.
Removed entireText from regex matches, as it was only used in one place and
could be derived from text before @, and username prefix.

Test Plan

Tested whole typeahead feature. Works!

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• przemek created this revision.Dec 15 2022, 4:11 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 15 2022, 4:11 AM

• przemek added a parent revision: D5850: [web] Introducing keyboard support for typeahead.Dec 15 2022, 4:11 AM

Harbormaster completed remote builds in B14167: Diff 19375.Dec 15 2022, 4:21 AM

• przemek requested review of this revision.Dec 15 2022, 4:21 AM

One more rename

Harbormaster completed remote builds in B14168: Diff 19376.Dec 15 2022, 5:39 AM

kamil accepted this revision.Dec 16 2022, 2:01 AM

kamil added a reviewer: tomek.

inka added inline comments.Dec 16 2022, 2:13 AM

web/utils/typeahead-utils.js
15–17 ↗	(On Diff #19376)	Is there a reason why the regex would be different on native?
77 ↗	(On Diff #19376)	Should't types start with a capital letter?

Rebasing

web/utils/typeahead-utils.js
15–17 ↗	(On Diff #19376)	Yeah, named capture groups are not there yet on Native. More here: https://linear.app/comm/issue/ENG-2456/rewrite-typeahead-regexes-when-named-capturing-groups-are-released-for
77 ↗	(On Diff #19376)	Fixed in previous diff.

Harbormaster completed remote builds in B14199: Diff 19428.Dec 16 2022, 3:05 AM

It's really hard to review a diff where so many things happen at the same time. This diff contains renaming, moving, some changes in logic... could you split this diff into multiple ones, so that each diff does one thing and can be easily verified?

This revision now requires changes to proceed.Dec 19 2022, 2:56 AM

• przemek abandoned this revision.Dec 22 2022, 4:51 AM

• przemek removed a parent revision: D5850: [web] Introducing keyboard support for typeahead.Dec 22 2022, 4:55 AM