Details

Reviewers

• jon
tomek

Commits

rCOMMc44111a770d8: clean up the repo a bit

Summary

Moved our implementation of the opaque-ke CipherSuite trait to a separate library to avoid repeating ourselves.
Deleted opaque-ke-cxx which we didn't end up using.
Updated .gitignore files.

Test Plan

rebuilt everything that I refactored to use the new comm-opaque library and it worked fine

Diff Detail

Repository

rCOMM Comm

Branch

new-master (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Dec 15 2022, 4:47 PM

Herald added a reviewer: • jon. · View Herald TranscriptDec 15 2022, 4:47 PM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 15 2022, 4:50 PM

Harbormaster failed remote builds in B14197: Diff 19426!

fix Dockerfile

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 1:54 PM

Harbormaster failed remote builds in B14473: Diff 19728!

rebase for CI

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 20 2022, 3:06 PM

Harbormaster failed remote builds in B14587: Diff 19893!

varun edited reviewers, added: tomek; removed: atul. varun added 1 blocking reviewer(s): • jon.Dec 20 2022, 3:07 PM

add newline to Cargo.toml

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 20 2022, 3:10 PM

Harbormaster failed remote builds in B14589: Diff 19895!

Harbormaster completed remote builds in B14589: Diff 19895.Dec 20 2022, 3:23 PM

varun requested review of this revision.Dec 20 2022, 3:23 PM

• jon accepted this revision.Dec 20 2022, 5:54 PM

tomek accepted this revision.Dec 21 2022, 6:45 AM

tomek added inline comments.

native/native_rust_library/Cargo.toml
17 ↗	(On Diff #19895)	Do we still need this?

This revision is now accepted and ready to land.Dec 21 2022, 6:45 AM

varun added a comment.Dec 21 2022, 10:54 AM

This comment was removed by varun.

native/native_rust_library/Cargo.toml
17 ↗	(On Diff #19895)	yeah because we use some other functions from this library directly

Closed by commit rCOMMc44111a770d8: clean up the repo a bit (authored by varun). · Explain WhyDec 21 2022, 11:36 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMc44111a770d8: clean up the repo a bit.

clean up the repo a bit
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 19893

.gitignore

native/cpp/CommonCpp/CryptoTools/opaque-ke-cxx/Cargo.lock

native/cpp/CommonCpp/CryptoTools/opaque-ke-cxx/Cargo.toml

native/cpp/CommonCpp/CryptoTools/opaque-ke-cxx/build.rs

native/cpp/CommonCpp/CryptoTools/opaque-ke-cxx/src/lib.rs

native/native_rust_library/Cargo.lock

native/native_rust_library/Cargo.toml

native/native_rust_library/src/identity_client.rs

native/native_rust_library/src/lib.rs

native/native_rust_library/src/opaque.rs

services/identity/Cargo.lock

services/identity/Cargo.toml

services/identity/Dockerfile

services/identity/src/database.rs

services/identity/src/keygen.rs

services/identity/src/lib.rs

services/identity/src/main.rs

services/identity/src/opaque.rs

services/identity/src/service.rs

services/identity/src/users.rs

shared/comm-opaque/.gitignore

shared/comm-opaque/Cargo.lock

shared/comm-opaque/Cargo.toml

shared/comm-opaque/src/lib.rs

shared/comm-opaque/src/opaque.rs

clean up the repo a bitClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19893

.gitignore

native/cpp/CommonCpp/CryptoTools/opaque-ke-cxx/Cargo.lock

native/cpp/CommonCpp/CryptoTools/opaque-ke-cxx/Cargo.toml

native/cpp/CommonCpp/CryptoTools/opaque-ke-cxx/build.rs

native/cpp/CommonCpp/CryptoTools/opaque-ke-cxx/src/lib.rs

native/native_rust_library/Cargo.lock

native/native_rust_library/Cargo.toml

native/native_rust_library/src/identity_client.rs

native/native_rust_library/src/lib.rs

native/native_rust_library/src/opaque.rs

services/identity/Cargo.lock

services/identity/Cargo.toml

services/identity/Dockerfile

services/identity/src/database.rs

services/identity/src/keygen.rs

services/identity/src/lib.rs

services/identity/src/main.rs

services/identity/src/opaque.rs

services/identity/src/service.rs

services/identity/src/users.rs

shared/comm-opaque/.gitignore

shared/comm-opaque/Cargo.lock

shared/comm-opaque/Cargo.toml

shared/comm-opaque/src/lib.rs

shared/comm-opaque/src/opaque.rs

clean up the repo a bit
ClosedPublic
Actions

Revision Contents
Changeset List