FAILED]` to `redux-types`
ClosedPublic
Actions

Authored by atul on Dec 20 2022, 11:26 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM273057633475: [lib] Add `GET_SIWE_NONCE_[STARTED/SUCCESS/FAILED]` to `redux-types`

Summary

Should've added these when I introduced lib/actions/siwe-actions.js:getSIWENonceActionTypes. Ran into a flow issue when I was trying to use createLoadingStatusSelector which flagged that something was missing.

Test Plan

Able to use createLoadingStatusSelector without issue later in the stack.

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D5964 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 20 2022, 11:26 PM

atul published this revision for review.Dec 20 2022, 11:26 PM

atul added a child revision: D5965: [lib] Fix return value of `getSIWENonce`.Dec 20 2022, 11:29 PM

Harbormaster completed remote builds in B14609: Diff 19929.Dec 20 2022, 11:40 PM

atul retitled this revision from [lib] Add `GET_SIWE_NONCE_[STARTED/SUCCESS/FAILED` to `redux-types` to [lib] Add `GET_SIWE_NONCE_[STARTED/SUCCESS/FAILED]` to `redux-types`.Dec 20 2022, 11:57 PM

tomek accepted this revision.Dec 21 2022, 8:34 AM

This revision is now accepted and ready to land.Dec 21 2022, 8:34 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 21 2022, 10:02 AM

Closed by commit rCOMM273057633475: [lib] Add `GET_SIWE_NONCE_[STARTED/SUCCESS/FAILED]` to `redux-types` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM273057633475: [lib] Add `GET_SIWE_NONCE_[STARTED/SUCCESS/FAILED]` to `redux-types`.

Harbormaster completed remote builds in B14635: Diff 19958.Dec 21 2022, 10:13 AM