Page MenuHomePhabricator
Differential D5967

[native/rust_library] Refactor Tonic client function name for Identity service
ClosedPublic
Actions

Authored by • max on Dec 21 2022, 4:53 AM.
Tags
None
Referenced Files
F3246387: D5967.id19934.diff
Thu, Nov 14, 11:25 PM
Unknown Object (File)
Wed, Nov 13, 5:20 AM
Unknown Object (File)
Mon, Nov 11, 10:29 PM
Unknown Object (File)
Mon, Nov 4, 3:15 AM
Unknown Object (File)
Mon, Nov 4, 3:15 AM
Unknown Object (File)
Mon, Nov 4, 3:14 AM
Unknown Object (File)
Mon, Nov 4, 3:14 AM
Unknown Object (File)
Sat, Oct 26, 12:44 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
varun
• jon
Commits
rCOMMefc75acf3796: [native/rust_library] Refactor Tonic client function name for Identity service
Summary

This diff introduces refactoring the Tonic client names for the Identity service in a Rust native library to the Client -> IdentityClient.
As we are using a single Rust library for the native which will contain clients and helper functions for all services we should refactor the Identity service-related function names to be more specific.
After this, we can add new clients for other services e.g. TunnelbrokerClient.

Linear task: ENG-1333

Test Plan

Rust library and native app are successfully built.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Dec 21 2022, 4:53 AM
• max held this revision as a draft.
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 21 2022, 4:53 AM
• max added a child revision: D5968: [native/rust_library] Refactor Tonic client utility function names for Identity service.Dec 21 2022, 4:55 AM
• max retitled this revision from [native/rust_library] Refactor Tonic client to use it from global to Identity service to [native/rust_library] Refactor Tonic client function name for Identity service.Dec 21 2022, 5:06 AM
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max added reviewers: varun, • jon.
Harbormaster completed remote builds in B14614: Diff 19934.Dec 21 2022, 5:06 AM
• max added inline comments.Dec 21 2022, 5:07 AM
native/native_rust_library/src/lib.rs
21–22 ↗(On Diff #19934)

We should remove the constant with the local address and pass it as a client initialization function argument.

• max published this revision for review.Dec 21 2022, 6:03 AM
varun accepted this revision.Dec 21 2022, 11:37 AM
varun added inline comments.
native/native_rust_library/src/lib.rs
21–22 ↗(On Diff #19934)

yup

This revision is now accepted and ready to land.Dec 21 2022, 11:37 AM
• max updated this revision to Diff 20228.Dec 28 2022, 7:23 AM
• max marked an inline comment as done.

Fix merging and rebasing on master.

Harbormaster failed remote builds in B14836: Diff 20228!Dec 28 2022, 7:36 AM
• max updated this revision to Diff 20233.Dec 28 2022, 7:38 AM

Rebasing.

Harbormaster failed remote builds in B14838: Diff 20233!Dec 28 2022, 7:42 AM
Harbormaster completed remote builds in B14838: Diff 20233.Dec 28 2022, 7:56 AM
Closed by commit rCOMMefc75acf3796: [native/rust_library] Refactor Tonic client function name for Identity service (authored by • max). · Explain WhyDec 28 2022, 7:58 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMMefc75acf3796: [native/rust_library] Refactor Tonic client function name for Identity service.

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
12 lines
34 lines

Diff 20236

View Options

native/native_rust_library/src/identity_client.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...