[native/rust_library] Removing of testing `hello.c` and increase C++ standard to 17 in `build.rs`
ClosedPublic
Actions

Authored by • max on Dec 23 2022, 5:30 PM.

Details

Reviewers

varun
• jon

Commits

rCOMM407f2a2c7d02: [native/rust_library] Removing of testing `hello.c` and increase C++ standard…

Summary

This diff introduces the following changes to the Cargo build.rs:

Removing the testing building of the hello.c based on the comment;
Increasing the C++ standard to 17, because RN now supports it.

Linear task: ENG-2536

Test Plan

Native CI gates are passed.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Dec 23 2022, 5:30 PM

• max held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 23 2022, 5:30 PM

• max added a parent revision: D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.Dec 23 2022, 5:31 PM

• max retitled this revision from [native/rust_library] Removing of testing `hello.c` and increase C++ standart to 17 in `build.rs` to [native/rust_library] Removing of testing `hello.c` and increase C++ standard to 17 in `build.rs`.Dec 23 2022, 5:35 PM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: varun, • jon.

Harbormaster completed remote builds in B14717: Diff 20070.Dec 23 2022, 5:45 PM

• max published this revision for review.Dec 23 2022, 5:51 PM

• max edited the summary of this revision. (Show Details)

• max mentioned this in D5807: [native/rust_library] Add Tunnelbroker protobuf file compilation to the native client.Dec 23 2022, 5:56 PM

We should probably rerun the build if the protos or lib.rs change

println!("cargo:rerun-if-changed=src/lib.rs");
println!("cargo:rerun-if-changed=../../shared/protos/identity.proto");
println!("cargo:rerun-if-changed=../../shared/protos/tunnelbroker.proto");

varun accepted this revision.Dec 27 2022, 3:03 PM

This revision is now accepted and ready to land.Dec 27 2022, 3:03 PM

Adding of rerun-if-changed for proto files and lib.rs.

In D6014#180778, @jon wrote:
We should probably rerun the build if the protos or lib.rs change
println!("cargo:rerun-if-changed=src/lib.rs");
println!("cargo:rerun-if-changed=../../shared/protos/identity.proto");
println!("cargo:rerun-if-changed=../../shared/protos/tunnelbroker.proto");

Good catch! Thanks, @jon!

Harbormaster failed remote builds in B14830: Diff 20221!Dec 28 2022, 2:46 PM

Rebasing on master.

Harbormaster completed remote builds in B14833: Diff 20224.Dec 28 2022, 3:03 PM

Closed by commit rCOMM407f2a2c7d02: [native/rust_library] Removing of testing `hello.c` and increase C++ standard…. · Explain WhyDec 28 2022, 3:10 PM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM407f2a2c7d02: [native/rust_library] Removing of testing `hello.c` and increase C++ standard….