Details
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Adding CMake people. Note that the Gradle stuff is heavily inspired by Expo stuff (see diff description)
| native/android/app/CMakeLists.txt | ||
|---|---|---|
| 5 | React Native 0.70 supports C++17 | |
| 79–104 | This used to be lower, but I moved it up. I think it makes more sense up at the top: it's defining the library we're compiling | |
| 130–132 | We no longer need to compile double conversion, we just need the headers | |
| 162–167 | We link against the Folly we extract from the pre-packaged React Native AAR, instead of compiling Folly ourselves | |
| 169 | Looking into CMake docs indicates target_compile_options is a better, more modern option than add_definitions | |
| 178 | Still doing add_definitions here because I didn't have time to test these other libraries and how the change might affect them | |
| native/android/app/CMakeLists.txt | ||
|---|---|---|
| 5 ↗ | (On Diff #19578) | React Native 0.70 supports C++17 |
| 79–104 ↗ | (On Diff #19578) | This used to be lower, but I moved it up. I think it makes more sense up at the top: it's defining the library we're compiling |
| 130–132 ↗ | (On Diff #19578) | We no longer need to compile double conversion, we just need the headers |
| 162–167 ↗ | (On Diff #19578) | We link against the Folly we extract from the pre-packaged React Native AAR, instead of compiling Folly ourselves |
| 169 ↗ | (On Diff #19578) | Looking into CMake docs indicates target_compile_options is a better, more modern option than add_definitions |
| 178 ↗ | (On Diff #19578) | Still doing add_definitions here because I didn't have time to test these other libraries and how the change might affect them |
(so we can use one that is M1-optimized)
Is this M1-specific or does it apply to Apple Silicon broadly?
Is this M1-specific or does it apply to Apple Silicon broadly?
As far as I understand, there's broadly no such thing as M1-specific. Whenever you read "M1" you can probably assume it's a legacy stand-in for "Apple Silicon". I'll try to use the proper term in the future
| native/android/app/CMakeLists.txt | ||
|---|---|---|
| 133–135 ↗ | (On Diff #19578) | I'm not sure... CMake is very complicated. I referenced what Expo is doing here, and they have the quotes. I'd rather not blow up the scope here to involve adding quotes everywhere, as I'm not sure what other thing that might affect, or whether I'd have to update some syntax somewhere or something |
| native/android/app/CMakeLists.txt | ||
|---|---|---|
| 92–96 ↗ | (On Diff #19578) | Should probably do another library for this, but I can do that as part of the GLOB RECURSE work. Created https://linear.app/comm/issue/ENG-2502 in the mean time. |
| 133–135 ↗ | (On Diff #19578) | Unless you need to perserve whitespace, it shouldn't matter much. From my experience, CMake seems to stringify most things by default. |