Paths

Table of Contentst

Differential D6039

[native/rust_library] Tunnelbroker client - Adding of the `get_nonce_to_sign` function
AbandonedPublic
Actions

Authored by varun on Dec 27 2022, 3:34 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 13, 5:23 AM

	Unknown Object (File)
	Sun, Nov 10, 5:55 PM

	Unknown Object (File)
	Wed, Nov 6, 3:35 PM

	Unknown Object (File)
	Mon, Nov 4, 1:19 AM

	Unknown Object (File)
	Mon, Nov 4, 1:19 AM

	Unknown Object (File)
	Sat, Nov 2, 3:32 AM

	Unknown Object (File)
	Sat, Nov 2, 3:32 AM

	Unknown Object (File)
	Sep 28 2024, 3:08 PM

View All 99 Files

Subscribers

Details

Reviewers

• jon
• max

Summary

This diff introduces the get_nonce_to_sign internal function which is a gRPC unary request to the Tunnelbroker server to obtain a nonce string to be signed. The function gets the pointer to the Tonic client and deviceID and returns the nonce from the server to be signed with the sign_string_with_private_key function from D5999.

This function also introduced a native_rust_library/src/tunnelbroker_client.rs file which will contain a requests functions.

Linear task: ENG-2434

Test Plan

Passing CI gates is enough because the Rust analyzer will catch any disparity between the gRPC request method and the gRPC proto schema.

Diff Detail

Repository

Branch

native-tb-client-add-nonce-to-sign-request

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Dec 27 2022, 3:34 AM

• max held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 27 2022, 3:34 AM

• max added a child revision: D6040: [native/rust_library] Tunnelbroker client - Adding of the `get_new_session_id` function.Dec 27 2022, 3:35 AM

• max added a parent revision: D5999: [native/rust_library] Adding `sign_string_with_private_key` function to crypto tools.

• max edited the summary of this revision. (Show Details)Dec 27 2022, 3:46 AM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: • jon, varun.

Harbormaster completed remote builds in B14772: Diff 20150.Dec 27 2022, 3:48 AM

• max edited the test plan for this revision. (Show Details)Dec 27 2022, 3:48 AM

• max published this revision for review.Dec 27 2022, 3:51 AM

• max mentioned this in D6040: [native/rust_library] Tunnelbroker client - Adding of the `get_new_session_id` function.

• max edited the summary of this revision. (Show Details)

Rubber stamping as there's no "smells", would like to eventually see a commtest around this

This revision is now accepted and ready to land.Dec 27 2022, 10:39 AM

Rebasing and merging.

Harbormaster failed remote builds in B14884: Diff 20301!Dec 29 2022, 2:21 AM

varun commandeered this revision.Jan 15 2024, 12:46 PM

varun abandoned this revision.

varun edited reviewers, added: • max; removed: varun.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

1 line

tunnelbroker_client.rs

17 lines

Diff 20301

native/native_rust_library/src/lib.rs

Loading...

native/native_rust_library/src/tunnelbroker_client.rs

Loading...