Differential D6074

[web] Delete comments disabling eslint checks
ClosedPublic
Actions

Authored by tomek on Dec 28 2022, 1:16 PM.

Tags

None

Referenced Files

	F5119838: D6074.diff
	Thu, Apr 3, 4:58 AM

	Unknown Object (File)
	Fri, Mar 28, 2:36 PM

	Unknown Object (File)
	Thu, Mar 13, 8:33 AM

	Unknown Object (File)
	Mar 3 2025, 7:22 PM

	Unknown Object (File)
	Mar 3 2025, 7:22 PM

	Unknown Object (File)
	Mar 3 2025, 7:21 PM

	Unknown Object (File)
	Mar 3 2025, 7:10 PM

	Unknown Object (File)
	Mar 3 2025, 8:05 AM

View All 73 Files

Subscribers

Details

Reviewers

kamil
inka
ginsu
• przemek
ashoat

Commits

rCOMM273bd39da8a1: [web] Delete comments disabling eslint checks

Summary

These comments were introduced during development of the feature and should've been deleted.

Depends on D5852

Test Plan

Flow / eslint

Diff Detail

Repository

Branch

ENG-2332

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Dec 28 2022, 1:16 PM

Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 28 2022, 1:16 PM

tomek edited the summary of this revision. (Show Details)Dec 28 2022, 1:17 PM

tomek added a parent revision: D6013: [web] Add copy-filled icon.

tomek edited the summary of this revision. (Show Details)

tomek added a parent revision: D5852: Introduce message copy button on web.

tomek removed a parent revision: D6013: [web] Add copy-filled icon.

Harbormaster completed remote builds in B14854: Diff 20259.Dec 28 2022, 1:31 PM

tomek requested review of this revision.Dec 28 2022, 1:31 PM

tomek added a child revision: D6075: [web] Add option to modify an existing tooltip.Dec 28 2022, 1:39 PM

Wish there was a way for ESLint to test if these are necessary and print an error asking you to delete them if not

This revision is now accepted and ready to land.Dec 28 2022, 5:19 PM

kamil accepted this revision.Dec 30 2022, 5:57 AM

Closed by commit rCOMM273bd39da8a1: [web] Delete comments disabling eslint checks (authored by tomek). · Explain WhyDec 30 2022, 8:09 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM273bd39da8a1: [web] Delete comments disabling eslint checks.

Revision Contents
Changeset List

Path

Size

web/

chat/

tooltip-provider.js

7 lines

Diff 20259

web/chat/tooltip-provider.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };