Details

Reviewers

atul
tomek

Commits

rCOMM6e4bd6322ea4: [keyserver/lib] introuce localID field to sendReactionMessage action and…

Summary

introuce localID field to sendReactionMessage action and reactionMessageCreationResponder. We need to do this to pass the localID to the server when creating new reaction messages

Depends on D6117
Linear Task: ENG-2519

Test Plan

flow this will be tested in subsequent diffs

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 30 2022, 11:41 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 30 2022, 11:41 PM

ginsu edited the summary of this revision. (Show Details)Dec 30 2022, 11:43 PM

ginsu added reviewers: atul, tomek.

ginsu added a parent revision: D6117: [lib] add localID field to reaction message type.

ginsu added a child revision: D6119: [web] introduce localID field to useOnClickReact hook.Dec 30 2022, 11:52 PM

Harbormaster completed remote builds in B14987: Diff 20456.Dec 30 2022, 11:54 PM

ginsu requested review of this revision.Dec 30 2022, 11:54 PM

tomek accepted this revision.Jan 2 2023, 1:10 PM

This revision is now accepted and ready to land.Jan 2 2023, 1:10 PM

rebase before landing

Harbormaster completed remote builds in B15198: Diff 20713.Jan 9 2023, 5:53 PM

Closed by commit rCOMM6e4bd6322ea4: [keyserver/lib] introuce localID field to sendReactionMessage action and…. · Explain WhyJan 9 2023, 6:05 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM6e4bd6322ea4: [keyserver/lib] introuce localID field to sendReactionMessage action and….

ashoat added inline comments.Jan 11 2023, 9:44 PM

keyserver/src/responders/message-responders.js
195	I think this is where you broke support for old clients. Any existing client won't include this, and you're requiring it here

Can we revert this diff please? New release won't solve the problem for old clients

ginsu added inline comments.Jan 11 2023, 9:48 PM

keyserver/src/responders/message-responders.js
195	Okay I got it now, thank you for clarifying. Will work on reverting diff rn

ginsu added a reverting change: D6244: Revert "[keyserver/lib] introuce localID field to sendReactionMessage action and reactionMessageCreationResponder".Jan 11 2023, 11:39 PM

ginsu added a reverting change: rCOMM24b904db30f8: Revert "[keyserver/lib] introuce localID field to sendReactionMessage action….Jan 12 2023, 3:51 AM

[keyserver/lib] introuce localID field to sendReactionMessage action and reactionMessageCreationResponder
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 20722

keyserver/src/responders/message-responders.js

lib/actions/message-actions.js

[keyserver/lib] introuce localID field to sendReactionMessage action and reactionMessageCreationResponderClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20722

keyserver/src/responders/message-responders.js

lib/actions/message-actions.js

[keyserver/lib] introuce localID field to sendReactionMessage action and reactionMessageCreationResponder
ClosedPublic
Actions

Revision Contents
Changeset List