Paths

Table of Contentst

Differential D6117

[lib] add localID field to reaction message type
ClosedPublic
Actions

Authored by ginsu on Dec 30 2022, 3:38 PM.

Tags

None

Referenced Files

	F2164750: D6117.id20524.diff
	Tue, Jul 2, 12:28 AM

	Unknown Object (File)
	Mon, Jul 1, 9:21 AM

	Unknown Object (File)
	Mon, Jul 1, 9:21 AM

	Unknown Object (File)
	Mon, Jul 1, 9:21 AM

	Unknown Object (File)
	Mon, Jul 1, 9:21 AM

	Unknown Object (File)
	Mon, Jul 1, 9:13 AM

	Unknown Object (File)
	Sat, Jun 29, 5:59 PM

	Unknown Object (File)
	Mon, Jun 24, 12:22 PM

Subscribers

Details

Reviewers

atul
tomek
ashoat

Commits

rCOMM3de73d0da05a: [lib] add localID field to reaction message type

Summary

add localID field to reaction message type. We are going to need this to create local reaction messages which we will display optimistically

Linear Task: ENG-2519

Test Plan

flow and will be testing more in subsequent diffs

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 30 2022, 3:38 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 30 2022, 3:38 PM

ginsu added reviewers: atul, tomek.Dec 30 2022, 3:39 PM

ginsu edited the summary of this revision. (Show Details)

ginsu edited the summary of this revision. (Show Details)Dec 30 2022, 3:42 PM

ginsu added a child revision: D6118: [keyserver/lib] introuce localID field to sendReactionMessage action and reactionMessageCreationResponder.

Harbormaster completed remote builds in B14986: Diff 20455.Dec 30 2022, 3:51 PM

ginsu requested review of this revision.Dec 30 2022, 3:51 PM

I wonder if this should be LocallyComposedMessageInfo. Looks like it's only use for CREATE_LOCAL_MESSAGE. Should we use that for reactions at all?

It sounds a little strange to say that reaction message is composable, but it shares a lot of properties with other composable message types, so I think it makes sense to include it in this set.

Requesting changes for an answer to my question above

This revision now requires changes to proceed.Jan 3 2023, 9:14 AM

add Reaction Message to LocallyComposedMessageInfo type

Harbormaster completed remote builds in B15044: Diff 20524.Jan 3 2023, 9:29 AM

Are we gonna use CREATE_LOCAL_MESSAGE for reactions? Guessing no, but I guess it didn't hurt to update LocallyComposedMessageInfo anyways

This revision is now accepted and ready to land.Jan 3 2023, 10:48 AM

Are we gonna use CREATE_LOCAL_MESSAGE for reactions? Guessing no, but I guess it didn't hurt to update LocallyComposedMessageInfo anyways

That is correct, we won't but since they share many similar properties, I figured adding it made sense

rebase before landing

Harbormaster completed remote builds in B15197: Diff 20712.Jan 9 2023, 9:53 AM

Closed by commit rCOMM3de73d0da05a: [lib] add localID field to reaction message type (authored by ginsu). · Explain WhyJan 9 2023, 10:04 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM3de73d0da05a: [lib] add localID field to reaction message type.

Revision Contents
Changeset List

Path

Size

lib/

shared/

message-utils.js

9 lines

types/

message-types.js

10 lines

messages/

6 lines

Diff 20721

lib/shared/message-utils.js

Loading...

lib/types/message-types.js

Loading...

lib/types/messages/reaction.js

Loading...