Page MenuHomePhabricator
Differential D6117

[lib] add localID field to reaction message type
ClosedPublic
Actions

Authored by ginsu on Dec 30 2022, 3:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 7:34 PM
Unknown Object (File)
Mon, Mar 17, 5:42 AM
Unknown Object (File)
Mon, Mar 17, 5:42 AM
Unknown Object (File)
Mon, Mar 17, 5:42 AM
Unknown Object (File)
Mon, Mar 17, 5:42 AM
Unknown Object (File)
Mon, Mar 17, 5:41 AM
Unknown Object (File)
Mon, Mar 17, 5:36 AM
Unknown Object (File)
Wed, Mar 12, 2:50 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
tomek
ashoat
Commits
rCOMM3de73d0da05a: [lib] add localID field to reaction message type
Summary

add localID field to reaction message type. We are going to need this to create local reaction messages which we will display optimistically

Linear Task: ENG-2519

Test Plan

flow and will be testing more in subsequent diffs

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 30 2022, 3:38 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 30 2022, 3:38 PM
ginsu added reviewers: atul, tomek.Dec 30 2022, 3:39 PM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the summary of this revision. (Show Details)Dec 30 2022, 3:42 PM
ginsu added a child revision: D6118: [keyserver/lib] introuce localID field to sendReactionMessage action and reactionMessageCreationResponder.
Harbormaster completed remote builds in B14986: Diff 20455.Dec 30 2022, 3:51 PM
ginsu requested review of this revision.Dec 30 2022, 3:51 PM
ashoat added a comment.Dec 30 2022, 9:01 PM

I wonder if this should be LocallyComposedMessageInfo. Looks like it's only use for CREATE_LOCAL_MESSAGE. Should we use that for reactions at all?

tomek accepted this revision.Jan 2 2023, 5:02 AM
tomek added a reviewer: ashoat.

It sounds a little strange to say that reaction message is composable, but it shares a lot of properties with other composable message types, so I think it makes sense to include it in this set.

ashoat requested changes to this revision.Jan 3 2023, 9:14 AM

Requesting changes for an answer to my question above

This revision now requires changes to proceed.Jan 3 2023, 9:14 AM
ginsu updated this revision to Diff 20524.Jan 3 2023, 9:15 AM
ginsu edited the summary of this revision. (Show Details)

add Reaction Message to LocallyComposedMessageInfo type

Harbormaster completed remote builds in B15044: Diff 20524.Jan 3 2023, 9:29 AM
ashoat accepted this revision.Jan 3 2023, 10:48 AM

Are we gonna use CREATE_LOCAL_MESSAGE for reactions? Guessing no, but I guess it didn't hurt to update LocallyComposedMessageInfo anyways

This revision is now accepted and ready to land.Jan 3 2023, 10:48 AM
ginsu added a comment.Jan 3 2023, 12:15 PM

Are we gonna use CREATE_LOCAL_MESSAGE for reactions? Guessing no, but I guess it didn't hurt to update LocallyComposedMessageInfo anyways

That is correct, we won't but since they share many similar properties, I figured adding it made sense

ginsu updated this revision to Diff 20712.Jan 9 2023, 9:38 AM

rebase before landing

Harbormaster completed remote builds in B15197: Diff 20712.Jan 9 2023, 9:53 AM
Closed by commit rCOMM3de73d0da05a: [lib] add localID field to reaction message type (authored by ginsu). · Explain WhyJan 9 2023, 10:04 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM3de73d0da05a: [lib] add localID field to reaction message type.

Revision Contents
Changeset List

PathSize
lib/
shared/
9 lines
types/
10 lines
messages/
6 lines

Diff 20712

View Options

lib/shared/message-utils.js

FROM node:16.13-bullseye FROM node:16.13-bullseye
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 0: INSTALL PREREQS # STEP 0: INSTALL PREREQS
# Install prereqs first so we don't have to reinstall them if anything changes # Install prereqs first so we don't have to reinstall them if anything changes
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# We use rsync in the prod-build yarn script # We add Debian's unstable repo since it's the only way to get mysqldump
RUN echo "deb http://deb.debian.org/debian unstable main non-free contrib" \
>> /etc/apt/sources.list
# We need rsync in the prod-build yarn script
# We need mysql-client so we can use mysqldump for backups
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
rsync \ rsync \
mysql-client \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 1: DEVOLVE PRIVILEGES # STEP 1: DEVOLVE PRIVILEGES
# Create another user to run the rest of the commands # Create another user to run the rest of the commands
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
RUN useradd -m comm RUN useradd -m comm
USER comm USER comm
WORKDIR /home/comm/app WORKDIR /home/comm/app
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 2: INSTALL NVM # STEP 2: SET UP MYSQL BACKUPS
# Prepare the system to properly handle mysqldump backups
#-------------------------------------------------------------------------------
# Prepare the directory that will hold the backups
RUN mkdir /home/comm/mysqldump
# We install mysql-client 8.0 above but use it with MySQL 5.7. Unfortunately,
# we haven't been able to figure out a way to install mysql-client 5.7 on
# Debian bullseye. Instead, we configure mysqldump 8.0 to work with MySQL 5.7
RUN echo "[mysqldump]\ncolumn-statistics=0" > /home/comm/.my.cnf
#-------------------------------------------------------------------------------
# STEP 3: INSTALL NVM
# We use nvm to make sure we're running the right Node version # We use nvm to make sure we're running the right Node version
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
ENV NVM_DIR /home/comm/.nvm ENV NVM_DIR /home/comm/.nvm
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh \ RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh \
| bash | bash
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 3: YARN CLEANINSTALL # STEP 4: YARN CLEANINSTALL
# We run yarn cleaninstall before copying most of the files in for build caching # We run yarn cleaninstall before copying most of the files in for build caching
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# Copy in package.json and yarn.lock files # Copy in package.json and yarn.lock files
COPY --chown=comm package.json yarn.lock . COPY --chown=comm package.json yarn.lock .
COPY --chown=comm keyserver/package.json keyserver/.flowconfig keyserver/ COPY --chown=comm keyserver/package.json keyserver/.flowconfig keyserver/
COPY --chown=comm lib/package.json lib/.flowconfig lib/ COPY --chown=comm lib/package.json lib/.flowconfig lib/
COPY --chown=comm web/package.json web/.flowconfig web/ COPY --chown=comm web/package.json web/.flowconfig web/
COPY --chown=comm native/package.json native/.flowconfig native/ COPY --chown=comm native/package.json native/.flowconfig native/
COPY --chown=comm landing/package.json landing/.flowconfig landing/ COPY --chown=comm landing/package.json landing/.flowconfig landing/
# Copy in files needed for patch-package and pod-patch # Copy in files needed for patch-package and pod-patch
COPY --chown=comm patches patches/ COPY --chown=comm patches patches/
COPY --chown=comm native/ios/pod-patch native/ios/pod-patch/ COPY --chown=comm native/ios/pod-patch native/ios/pod-patch/
COPY --chown=comm native/ios/Podfile native/ios/ COPY --chown=comm native/ios/Podfile native/ios/
# Actually run yarn # Actually run yarn
RUN yarn cleaninstall RUN yarn cleaninstall
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 4: WEBPACK BUILD # STEP 5: WEBPACK BUILD
# We do this first so Docker doesn't rebuild when only keyserver files change # We do this first so Docker doesn't rebuild when only keyserver files change
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
COPY --chown=comm lib lib/ COPY --chown=comm lib lib/
COPY --chown=comm landing landing/ COPY --chown=comm landing landing/
RUN yarn workspace landing prod RUN yarn workspace landing prod
COPY --chown=comm web web/ COPY --chown=comm web web/
RUN yarn workspace web prod RUN yarn workspace web prod
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 5: COPY IN SOURCE FILES # STEP 6: COPY IN SOURCE FILES
# We run this later so the above layers are cached if only source files change # We run this later so the above layers are cached if only source files change
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
COPY --chown=comm . . COPY --chown=comm . .
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 6: RUN BUILD SCRIPTS # STEP 7: RUN BUILD SCRIPTS
# We need to populate keyserver/dist, among other things # We need to populate keyserver/dist, among other things
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# Babel transpilation of keyserver src # Babel transpilation of keyserver src
RUN yarn workspace keyserver prod-build RUN yarn workspace keyserver prod-build
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 7: RUN THE SERVER # STEP 8: RUN THE SERVER
# Actually run the Node.js keyserver using nvm # Actually run the Node.js keyserver using nvm
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
EXPOSE 3000 EXPOSE 3000
WORKDIR /home/comm/app/keyserver WORKDIR /home/comm/app/keyserver
CMD bash/run-prod.sh CMD bash/run-prod.sh
View Options

lib/types/message-types.js

FROM node:16.13-bullseye FROM node:16.13-bullseye
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 0: INSTALL PREREQS # STEP 0: INSTALL PREREQS
# Install prereqs first so we don't have to reinstall them if anything changes # Install prereqs first so we don't have to reinstall them if anything changes
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# We use rsync in the prod-build yarn script # We add Debian's unstable repo since it's the only way to get mysqldump
RUN echo "deb http://deb.debian.org/debian unstable main non-free contrib" \
>> /etc/apt/sources.list
# We need rsync in the prod-build yarn script
# We need mysql-client so we can use mysqldump for backups
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
rsync \ rsync \
mysql-client \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 1: DEVOLVE PRIVILEGES # STEP 1: DEVOLVE PRIVILEGES
# Create another user to run the rest of the commands # Create another user to run the rest of the commands
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
RUN useradd -m comm RUN useradd -m comm
USER comm USER comm
WORKDIR /home/comm/app WORKDIR /home/comm/app
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 2: INSTALL NVM # STEP 2: SET UP MYSQL BACKUPS
# Prepare the system to properly handle mysqldump backups
#-------------------------------------------------------------------------------
# Prepare the directory that will hold the backups
RUN mkdir /home/comm/mysqldump
# We install mysql-client 8.0 above but use it with MySQL 5.7. Unfortunately,
# we haven't been able to figure out a way to install mysql-client 5.7 on
# Debian bullseye. Instead, we configure mysqldump 8.0 to work with MySQL 5.7
RUN echo "[mysqldump]\ncolumn-statistics=0" > /home/comm/.my.cnf
#-------------------------------------------------------------------------------
# STEP 3: INSTALL NVM
# We use nvm to make sure we're running the right Node version # We use nvm to make sure we're running the right Node version
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
ENV NVM_DIR /home/comm/.nvm ENV NVM_DIR /home/comm/.nvm
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh \ RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh \
| bash | bash
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 3: YARN CLEANINSTALL # STEP 4: YARN CLEANINSTALL
# We run yarn cleaninstall before copying most of the files in for build caching # We run yarn cleaninstall before copying most of the files in for build caching
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# Copy in package.json and yarn.lock files # Copy in package.json and yarn.lock files
COPY --chown=comm package.json yarn.lock . COPY --chown=comm package.json yarn.lock .
COPY --chown=comm keyserver/package.json keyserver/.flowconfig keyserver/ COPY --chown=comm keyserver/package.json keyserver/.flowconfig keyserver/
COPY --chown=comm lib/package.json lib/.flowconfig lib/ COPY --chown=comm lib/package.json lib/.flowconfig lib/
COPY --chown=comm web/package.json web/.flowconfig web/ COPY --chown=comm web/package.json web/.flowconfig web/
COPY --chown=comm native/package.json native/.flowconfig native/ COPY --chown=comm native/package.json native/.flowconfig native/
COPY --chown=comm landing/package.json landing/.flowconfig landing/ COPY --chown=comm landing/package.json landing/.flowconfig landing/
# Copy in files needed for patch-package and pod-patch # Copy in files needed for patch-package and pod-patch
COPY --chown=comm patches patches/ COPY --chown=comm patches patches/
COPY --chown=comm native/ios/pod-patch native/ios/pod-patch/ COPY --chown=comm native/ios/pod-patch native/ios/pod-patch/
COPY --chown=comm native/ios/Podfile native/ios/ COPY --chown=comm native/ios/Podfile native/ios/
# Actually run yarn # Actually run yarn
RUN yarn cleaninstall RUN yarn cleaninstall
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 4: WEBPACK BUILD # STEP 5: WEBPACK BUILD
# We do this first so Docker doesn't rebuild when only keyserver files change # We do this first so Docker doesn't rebuild when only keyserver files change
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
COPY --chown=comm lib lib/ COPY --chown=comm lib lib/
COPY --chown=comm landing landing/ COPY --chown=comm landing landing/
RUN yarn workspace landing prod RUN yarn workspace landing prod
COPY --chown=comm web web/ COPY --chown=comm web web/
RUN yarn workspace web prod RUN yarn workspace web prod
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 5: COPY IN SOURCE FILES # STEP 6: COPY IN SOURCE FILES
# We run this later so the above layers are cached if only source files change # We run this later so the above layers are cached if only source files change
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
COPY --chown=comm . . COPY --chown=comm . .
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 6: RUN BUILD SCRIPTS # STEP 7: RUN BUILD SCRIPTS
# We need to populate keyserver/dist, among other things # We need to populate keyserver/dist, among other things
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# Babel transpilation of keyserver src # Babel transpilation of keyserver src
RUN yarn workspace keyserver prod-build RUN yarn workspace keyserver prod-build
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 7: RUN THE SERVER # STEP 8: RUN THE SERVER
# Actually run the Node.js keyserver using nvm # Actually run the Node.js keyserver using nvm
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
EXPOSE 3000 EXPOSE 3000
WORKDIR /home/comm/app/keyserver WORKDIR /home/comm/app/keyserver
CMD bash/run-prod.sh CMD bash/run-prod.sh
View Options

lib/types/messages/reaction.js

FROM node:16.13-bullseye FROM node:16.13-bullseye
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 0: INSTALL PREREQS # STEP 0: INSTALL PREREQS
# Install prereqs first so we don't have to reinstall them if anything changes # Install prereqs first so we don't have to reinstall them if anything changes
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# We use rsync in the prod-build yarn script # We add Debian's unstable repo since it's the only way to get mysqldump
RUN echo "deb http://deb.debian.org/debian unstable main non-free contrib" \
>> /etc/apt/sources.list
# We need rsync in the prod-build yarn script
# We need mysql-client so we can use mysqldump for backups
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
rsync \ rsync \
mysql-client \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 1: DEVOLVE PRIVILEGES # STEP 1: DEVOLVE PRIVILEGES
# Create another user to run the rest of the commands # Create another user to run the rest of the commands
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
RUN useradd -m comm RUN useradd -m comm
USER comm USER comm
WORKDIR /home/comm/app WORKDIR /home/comm/app
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 2: INSTALL NVM # STEP 2: SET UP MYSQL BACKUPS
# Prepare the system to properly handle mysqldump backups
#-------------------------------------------------------------------------------
# Prepare the directory that will hold the backups
RUN mkdir /home/comm/mysqldump
# We install mysql-client 8.0 above but use it with MySQL 5.7. Unfortunately,
# we haven't been able to figure out a way to install mysql-client 5.7 on
# Debian bullseye. Instead, we configure mysqldump 8.0 to work with MySQL 5.7
RUN echo "[mysqldump]\ncolumn-statistics=0" > /home/comm/.my.cnf
#-------------------------------------------------------------------------------
# STEP 3: INSTALL NVM
# We use nvm to make sure we're running the right Node version # We use nvm to make sure we're running the right Node version
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
ENV NVM_DIR /home/comm/.nvm ENV NVM_DIR /home/comm/.nvm
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh \ RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh \
| bash | bash
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 3: YARN CLEANINSTALL # STEP 4: YARN CLEANINSTALL
# We run yarn cleaninstall before copying most of the files in for build caching # We run yarn cleaninstall before copying most of the files in for build caching
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# Copy in package.json and yarn.lock files # Copy in package.json and yarn.lock files
COPY --chown=comm package.json yarn.lock . COPY --chown=comm package.json yarn.lock .
COPY --chown=comm keyserver/package.json keyserver/.flowconfig keyserver/ COPY --chown=comm keyserver/package.json keyserver/.flowconfig keyserver/
COPY --chown=comm lib/package.json lib/.flowconfig lib/ COPY --chown=comm lib/package.json lib/.flowconfig lib/
COPY --chown=comm web/package.json web/.flowconfig web/ COPY --chown=comm web/package.json web/.flowconfig web/
COPY --chown=comm native/package.json native/.flowconfig native/ COPY --chown=comm native/package.json native/.flowconfig native/
COPY --chown=comm landing/package.json landing/.flowconfig landing/ COPY --chown=comm landing/package.json landing/.flowconfig landing/
# Copy in files needed for patch-package and pod-patch # Copy in files needed for patch-package and pod-patch
COPY --chown=comm patches patches/ COPY --chown=comm patches patches/
COPY --chown=comm native/ios/pod-patch native/ios/pod-patch/ COPY --chown=comm native/ios/pod-patch native/ios/pod-patch/
COPY --chown=comm native/ios/Podfile native/ios/ COPY --chown=comm native/ios/Podfile native/ios/
# Actually run yarn # Actually run yarn
RUN yarn cleaninstall RUN yarn cleaninstall
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 4: WEBPACK BUILD # STEP 5: WEBPACK BUILD
# We do this first so Docker doesn't rebuild when only keyserver files change # We do this first so Docker doesn't rebuild when only keyserver files change
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
COPY --chown=comm lib lib/ COPY --chown=comm lib lib/
COPY --chown=comm landing landing/ COPY --chown=comm landing landing/
RUN yarn workspace landing prod RUN yarn workspace landing prod
COPY --chown=comm web web/ COPY --chown=comm web web/
RUN yarn workspace web prod RUN yarn workspace web prod
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 5: COPY IN SOURCE FILES # STEP 6: COPY IN SOURCE FILES
# We run this later so the above layers are cached if only source files change # We run this later so the above layers are cached if only source files change
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
COPY --chown=comm . . COPY --chown=comm . .
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 6: RUN BUILD SCRIPTS # STEP 7: RUN BUILD SCRIPTS
# We need to populate keyserver/dist, among other things # We need to populate keyserver/dist, among other things
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# Babel transpilation of keyserver src # Babel transpilation of keyserver src
RUN yarn workspace keyserver prod-build RUN yarn workspace keyserver prod-build
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 7: RUN THE SERVER # STEP 8: RUN THE SERVER
# Actually run the Node.js keyserver using nvm # Actually run the Node.js keyserver using nvm
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
EXPOSE 3000 EXPOSE 3000
WORKDIR /home/comm/app/keyserver WORKDIR /home/comm/app/keyserver
CMD bash/run-prod.sh CMD bash/run-prod.sh