[web] introduce localID field to useOnClickReact hook
ClosedPublic
Actions

Authored by ginsu on Dec 30 2022, 3:45 PM.

Details

Reviewers

atul
tomek

Commits

rCOMMd3b9a79ac66b: [web] introduce localID field to useOnClickReact hook

Summary

introduce localID field to useOnClickReact hook. This diff also handles creating the localID variable on the client using the localIDPrefix and nextLocalID state

Depends on D6118
Linear Task: ENG-2519

Test Plan

Please watch this demo video to show that we were able to get the localID succesfully from the client to db

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 30 2022, 3:45 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 30 2022, 3:45 PM

ginsu edited the summary of this revision. (Show Details)Dec 30 2022, 3:52 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, tomek.

ginsu added a parent revision: D6118: [keyserver/lib] introuce localID field to sendReactionMessage action and reactionMessageCreationResponder.

ginsu attached a referenced file: F312064: Screen Recording 2022-12-30 at 6.48.50 PM.mov. (Show Details)

Harbormaster completed remote builds in B14988: Diff 20457.Dec 30 2022, 3:59 PM

ginsu requested review of this revision.Dec 30 2022, 3:59 PM

ginsu added a child revision: D6120: [native] introduce localID field to onPressReact function.Dec 30 2022, 4:04 PM

We also need to increase the next local id when a message is sent, but I guess it is handled later in the stack.

This revision is now accepted and ready to land.Jan 2 2023, 5:17 AM

Checked the rest of the stack and it doesn't seem like incrementing the id is handled. We should extend local-id-reducer to react on appropriate action.

To test this thoroughly, we can use a following scenario:

Send a reaction request and add a sleep on server side
Send a text message without a sleep (so that it finishes before reaction response)
Finish sleeping on server side

This scenario might cause some issues when incrementation isn't performed.

This revision now requires changes to proceed.Jan 2 2023, 5:23 AM

Checked the rest of the stack and it doesn't seem like incrementing the id is handled. We should extend local-id-reducer to react on appropriate action.

Just added D6123 to the stack which should address these concerns

tomek accepted this revision.Jan 5 2023, 4:00 AM

This revision is now accepted and ready to land.Jan 5 2023, 4:00 AM