handle send reaction message action failed case. Since there is no retry behavior for failed reaction messages right now, if a reaction message fails to get sent, I remove the local reaction message from the message store, and an alert telling the user that the message failed to send pops up
Details
Details
Please watch the demo videos to see how the redux state changes when a sent reaction message action starts:
Native:
Web:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/reducers/message-reducer.js | ||
|---|---|---|
| 1015 ↗ | (On Diff #20532) | Shouldn't we also filter this? Are we adding pending reaction messages to it? |
| lib/reducers/message-reducer.js | ||
|---|---|---|
| 1015 ↗ | (On Diff #20532) | We don't need to filter this because we are not adding pending reaction messages to it. Eventually we should add pending reaction messages to local when we want to implement retry behavior.  |
| lib/reducers/message-reducer.js | ||
|---|---|---|
| 1015 ↗ | (On Diff #20532) | Ok, that makes sense. But I'm wondering now if it would be safer if we took local from the processed store. return {
messageStoreOperations,
messageStore: {
...processedMessageStore,
threads: {
...messageStore.threads,
[threadID]: {
...messageStore.threads[threadID],
messageIDs: newMessageIDs,
},
},
},
}; |