Paths

Table of Contentst

Differential D6128

[landing] Add `siwePrimaryIdentityPublicKey` to `SIWEContext`
ClosedPublic
Actions

Authored by atul on Dec 31 2022, 2:28 AM.

Tags

None

Referenced Files

	F3753264: D6128.diff
	Fri, Jan 10, 1:29 AM

	Unknown Object (File)
	Thu, Dec 26, 8:17 AM

	Unknown Object (File)
	Thu, Dec 26, 8:17 AM

	Unknown Object (File)
	Thu, Dec 26, 8:17 AM

	Unknown Object (File)
	Thu, Dec 26, 8:15 AM

	Unknown Object (File)
	Thu, Dec 26, 8:05 AM

	Unknown Object (File)
	Dec 2 2024, 3:33 PM

	Unknown Object (File)
	Dec 2 2024, 3:33 PM

Subscribers

None

Details

Reviewers

ashoat
tomek

Commits

rCOMM5025b404144a: [landing] Add `siwePrimaryIdentityPublicKey` to `SIWEContext`

Summary

Add siwePrimaryIdentityPublicKey to SIWEContext so the value is available throughout landing without prop drilling. Specifically we'll be using siwePrimaryIdentityPublicKey in siwe.react.js where we'll need the public key so it can be included in the SIWE message that gets signed by the user's wallet.

Depends on D6127

Test Plan

Able to retrieve the value of siwePrimaryIdentityPublicKey in siwe.react.js:
https://blob.sh/ef0479.png (yeah contrast isn't great, but the public key is there as expected).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 31 2022, 2:28 AM

atul published this revision for review.Dec 31 2022, 2:38 AM

Harbormaster completed remote builds in B15000: Diff 20477.Dec 31 2022, 2:42 AM

atul edited the summary of this revision. (Show Details)Dec 31 2022, 2:54 AM

atul added a child revision: D6129: [lib] Introduce `getSIWEStatementForPublicKey(...)`.

atul edited the summary of this revision. (Show Details)Dec 31 2022, 3:20 AM

atul added a parent revision: D6127: [landing] Rename `SIWENonceContext` to `SIWEContext`.

ashoat accepted this revision.Jan 1 2023, 7:53 PM

This revision is now accepted and ready to land.Jan 1 2023, 7:53 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jan 3 2023, 1:29 PM

Closed by commit rCOMM5025b404144a: [landing] Add `siwePrimaryIdentityPublicKey` to `SIWEContext` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM5025b404144a: [landing] Add `siwePrimaryIdentityPublicKey` to `SIWEContext`.

Harbormaster completed remote builds in B15052: Diff 20533.Jan 3 2023, 1:44 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

landing-handler.js

1 line

landing/

landing-ssr.react.js

6 lines

2 lines

siwe-context.js

2 lines

Diff 20534

keyserver/src/responders/landing-handler.js

Loading...

landing/landing-ssr.react.js

Loading...

landing/root.js

Loading...

landing/siwe-context.js

Loading...