Page MenuHomePhabricator
Differential D6175

[desktop] Type bridge object between desktop and web
ClosedPublic
Actions

Authored by michal on Jan 5 2023, 4:53 AM.
Tags
None
Referenced Files
F3508465: D6175.diff
Fri, Dec 20, 10:19 PM
Unknown Object (File)
Sat, Nov 30, 12:54 AM
Unknown Object (File)
Sat, Nov 30, 12:54 AM
Unknown Object (File)
Sat, Nov 30, 12:54 AM
Unknown Object (File)
Thu, Nov 28, 11:30 AM
Unknown Object (File)
Thu, Nov 28, 4:06 AM
Unknown Object (File)
Fri, Nov 22, 4:10 AM
Unknown Object (File)
Fri, Nov 22, 4:10 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
ginsu
inka
ashoat
Commits
rCOMM21395b9f8ad8: [desktop] Type bridge object between desktop and web
Summary

ENG-2219
Previously this bridge object (through which we send messages between electron and web app) was typed only on web. This diff moves the types to lib and uses them on desktop to keep everything in sync.

Test Plan

Run flow in desktop and web.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
desktop/
src/
4 lines
lib/
types/
14 lines
web/
17 lines

Diff 20613

View Options

desktop/src/preload.js

Loading...
View Options

lib/types/electron-types.js

Loading...
View Options

web/electron.js

Loading...