Use -type d to make the command not error with GNU findutils.
Details
Details
On a mac, which has BSD Tools $ cd services $ ./scripts/list_services.sh $ nix develop $ ./scripts/list_services.sh # Should produce the same output # Run calling script yarn run-integration-tests blob
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- jonringer/fix-find
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
This works, but the output is different than original:
# original output identity tunnelbroker backup blob # new output ./identity ./tunnelbroker ./backup ./blob
This impacts other commands using it: yarn run-integration-tests blob fails with
No such service: blob Expected one of these: ./identity ./tunnelbroker ./backup ./blob all
This isn't a big issue though, as yarn run-integration-tests ./blob works but this probably requires updating some docs and testing other commands. So stripping ./ would be a better option
Comment Actions
Can you amend the test plan to include calling yarn run-integration-tests ./blob? Remember my advice about increasing the scope of your test plan... you don't just want to test the immediate change you're making, you want to test the things it affects
Comment Actions
Also please git grep through the project to see where else this command is being used, and add all of the results to the Test Plan. I really think it's what you should aim for on every diff, and that it's not excessive
Comment Actions
Update:
Noticed that adding ./ to service name when calling yarn run-integration-tests ./blob doesn't fix the issue as no tests are matched (the inner cargo test "./blob" command succeeds with 0 tests being run).
Comment Actions
This works, but the output is different than original:
Oops, that was my bad
Also please git grep through the project to see where else this command is being used, and add all of the results to the Test Plan. I really think it's what you should aim for on every diff, and that it's not excessive
Only other services place is ran within docker image, which is already GNU find
$ rg 'find ' ... services/lib/docker/run_service.sh 7:EXE=$(find $EXE_PATH -mindepth 1 -maxdepth 1 -not -path '*/.*')
This is already used within the nix context
nix/start-powerline.sh 60: find "$powerline_fonts" \
And this hook should already being ran (or maybe not, because clang support might not be 100%)
scripts/get_clang_paths_cli.js
9: command += `find ${path} `;Can you amend the test plan to include calling yarn run-integration-tests ./blob? Remember my advice about increasing the scope of your test plan... you don't just want to test the immediate change you're making, you want to test the things it affects
Amended, not sure why I didn't run the integration tests.