[native] Add fontSize option to Pill and ThreadPill components
ClosedPublic
Actions

Authored by inka on Jan 13 2023, 5:17 AM.

Details

Reviewers

• przemek
bartek
kamil
tomek

Commits

rCOMM9428fc7d7cba: [native] Add fontSize option to Pill and ThreadPill components

Summary

Adding the possibility to change font size in Pill/ThreadPill components, because I'll need that in subchannels/sidebars modals, as discussed in
https://linear.app/comm/issue/ENG-2547/restyle-sidebarlistmodal-and-subchannelslistmodal

Test Plan

Run ios simulator, check that pills display correctly - ex in chat settings. Check that passing a fontSize prop changes the fon size.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jan 13 2023, 5:17 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 13 2023, 5:17 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 13 2023, 5:19 AM

Harbormaster failed remote builds in B15348: Diff 20928!

I thought of just allowing to pass a whole style, but I think it's good if we don't encourage diverging from the used style too much. Just like we didn't allow to pass any boarder radius values, just a boolean whether left and right corners should be rounded. So I just added what I needed.

Harbormaster completed remote builds in B15348: Diff 20928.Jan 16 2023, 1:08 AM

inka requested review of this revision.Jan 16 2023, 1:08 AM

bartek accepted this revision.Jan 16 2023, 11:52 PM

This revision is now accepted and ready to land.Jan 16 2023, 11:52 PM

inka added a reviewer: tomek.Jan 17 2023, 4:41 AM

This revision now requires review to proceed.Jan 17 2023, 4:41 AM

tomek accepted this revision.Jan 18 2023, 2:08 AM

This revision is now accepted and ready to land.Jan 18 2023, 2:08 AM

Closed by commit rCOMM9428fc7d7cba: [native] Add fontSize option to Pill and ThreadPill components (authored by • InkaSokolowska). · Explain WhyJan 19 2023, 1:14 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMM9428fc7d7cba: [native] Add fontSize option to Pill and ThreadPill components.