Paths

Table of Contentst

Differential D6278

[tunnelbroker-client] Adding `shared/tunnelbroker-client` target folder to the `.gitignore`
ClosedPublic
Actions

Authored by • max on Jan 17 2023, 5:58 AM.

Tags

None

Referenced Files

	F1794709: D6278.diff
	Sun, May 19, 3:28 PM

	Unknown Object (File)
	Mon, May 6, 1:29 PM

	Unknown Object (File)
	Mon, May 6, 1:29 PM

	Unknown Object (File)
	Mon, May 6, 1:29 PM

	Unknown Object (File)
	Mon, May 6, 1:29 PM

	Unknown Object (File)
	Mon, May 6, 12:41 PM

	Unknown Object (File)
	Apr 5 2024, 2:43 PM

	Unknown Object (File)
	Apr 5 2024, 2:34 PM

View All 40 Files

Subscribers

Details

Reviewers

• jon
varun
ashoat

Commits

rCOMM121a4d546a1a: [tunnelbroker-client] Adding `shared/tunnelbroker-client` target folder to the…

Summary

This diff introduces adding of the shared/tunnelbroker-client/target folder to the global .gitignore file.
The reason to add this folder is that the client shared library can be built and tested in an isolated way and will produce temporary build files during the Cargo building and testing process using cargo test or cargo build.

Linear task: ENG-2728

Test Plan

Running cargo build or cargo test will produce temporary files in the shared/tunnelbroker-client/target directory.

Diff Detail

Repository

Branch

tb-add-shared-to-gitignore

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Jan 17 2023, 5:58 AM

• max held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 17 2023, 5:58 AM

Harbormaster failed remote builds in B15393: Diff 20993!Jan 17 2023, 6:02 AM

• max added a parent revision: D6277: [tunnelbroker-client] Creating a Cargo project file.Jan 17 2023, 7:00 AM

• max published this revision for review.Jan 17 2023, 7:04 AM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: • jon, varun.

• max added a child revision: D6279: [tunnelbroker-client] Adding of the `build.rs` cargo file to compile protobuf.Jan 17 2023, 7:09 AM

• jon accepted this revision.Jan 17 2023, 11:14 AM

This revision is now accepted and ready to land.Jan 17 2023, 11:14 AM

• max added a reviewer: ashoat.Jan 25 2023, 4:58 AM

This revision now requires review to proceed.Jan 25 2023, 4:58 AM

Adding @ashoat for a final pass.

ashoat accepted this revision.Jan 25 2023, 6:27 AM

This revision is now accepted and ready to land.Jan 25 2023, 6:27 AM

Rebasing.

Harbormaster completed remote builds in B15933: Diff 21755.Feb 1 2023, 6:56 AM

Closed by commit rCOMM121a4d546a1a: [tunnelbroker-client] Adding `shared/tunnelbroker-client` target folder to the… (authored by • max). · Explain WhyFeb 1 2023, 6:57 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM121a4d546a1a: [tunnelbroker-client] Adding `shared/tunnelbroker-client` target folder to the….

Revision Contents
Changeset List

Path

Size

3 lines

Diff 20993

.gitignore

Loading...