Details

Reviewers

• jon
varun

Commits

rCOMM198b5282a027: [tunnelbroker-client] Adding Tunnelbroker tonic client initialization function

Summary

This diff introduces an initialize_client function that initializes the Tonic client instance and returns a client channel for it. The client instance from this function will be passed as an argument into the publish and consume functions in the follow-up diffs.

Linear task: ENG-2728

Test Plan

Running of run nix develop --accept-flake-config -c bash -c "cargo test" will successfully build the library.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Jan 17 2023, 6:29 AM

• max held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 17 2023, 6:29 AM

Harbormaster completed remote builds in B15397: Diff 20996.Jan 17 2023, 6:44 AM

• max mentioned this in D6277: [tunnelbroker-client] Creating a Cargo project file.Jan 17 2023, 6:51 AM

• max mentioned this in D6279: [tunnelbroker-client] Adding of the `build.rs` cargo file to compile protobuf.Jan 17 2023, 7:09 AM

• max published this revision for review.Jan 17 2023, 7:15 AM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: • jon, varun.

• max added a parent revision: D6279: [tunnelbroker-client] Adding of the `build.rs` cargo file to compile protobuf.

Compiling tunnelbroker-client v0.1.0 (/home/jon/comm/comm/shared/tunnelbroker-client)
Compiling h2 v0.3.15
Compiling tower v0.4.13
Compiling tower-http v0.3.5
Compiling hyper v0.14.23
Compiling hyper-timeout v0.4.1
Compiling tonic v0.8.3
 Finished dev [unoptimized + debuginfo] target(s) in 48.53s

This revision is now accepted and ready to land.Jan 17 2023, 11:16 AM

• max added a child revision: D6282: [buildkite] Adding CI test for the Tunnelbroker client shared library.Jan 25 2023, 4:56 AM

• max added 1 blocking reviewer(s): varun.Jan 25 2023, 4:59 AM

This revision now requires review to proceed.Jan 25 2023, 4:59 AM

• max added a child revision: D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.Jan 25 2023, 5:40 AM

varun accepted this revision.Jan 25 2023, 12:19 PM

varun added inline comments.

shared/tunnelbroker-client/src/lib.rs
27 ↗	(On Diff #20996)	this isn't exactly right, is it? we just failed to run the future to completion

This revision is now accepted and ready to land.Jan 25 2023, 12:19 PM

• max added a child revision: D6284: [tunnelbroker-client] Adding `publish_message` client function.Jan 30 2023, 12:05 AM

Changing imported protobuff codegen name from tunnelbroker to the protobuff and making it public.
Fixing expect error message.

• max marked an inline comment as done.Jan 30 2023, 12:10 AM

• max added inline comments.

shared/tunnelbroker-client/src/lib.rs
27 ↗	(On Diff #20996)	this isn't exactly right, is it? we just failed to run the future to completion Yes, that's right! Fixed, thanks for catching it.