Page MenuHomePhabricator
Differential D6312

[services][backup] Remove old C++ implementation
ClosedPublic
Actions

Authored by bartek on Jan 19 2023, 11:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 16, 7:54 AM
Unknown Object (File)
Sun, Feb 16, 7:54 AM
Unknown Object (File)
Sun, Feb 16, 7:54 AM
Unknown Object (File)
Sun, Feb 16, 7:48 AM
Unknown Object (File)
Sun, Feb 9, 3:06 AM
Unknown Object (File)
Thu, Jan 30, 9:33 PM
Unknown Object (File)
Thu, Jan 30, 9:33 PM
Unknown Object (File)
Thu, Jan 30, 9:33 PM
View All Files
Subscribers
atul
tomek

Details

Reviewers
• jon
varun
ashoat
Commits
rCOMMaf2470e1e909: [services][backup] Remove old C++ implementation
Summary

Rust implementation of Backup service is landed. The "old" C++ implementation can now be removed.

This also removes the "old blob client" that was failing in non-docker environment - see D6291

Test Plan

None. CI no longer depends on this, should not fail.

Diff Detail

Repository
rCOMM Comm
Branch
barthap/delete-backup-cpp
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jan 19 2023, 11:46 AM
bartek held this revision as a draft.
Herald added subscribers: atul, tomek. · View Herald TranscriptJan 19 2023, 11:46 AM
Harbormaster completed remote builds in B15481: Diff 21120.Jan 19 2023, 12:01 PM
bartek published this revision for review.Jan 19 2023, 12:10 PM
bartek mentioned this in D6310: Lint all Rust projects in pre-commit.
ashoat accepted this revision.Jan 19 2023, 2:10 PM

Has blob_client been replaced or moved?

This revision is now accepted and ready to land.Jan 19 2023, 2:10 PM
bartek added a comment.Jan 20 2023, 12:28 AM
In D6312#189187, @ashoat wrote:

Has blob_client been replaced or moved?

It was replaced by a module integrated directly into the backup crate.

Closed by commit rCOMMaf2470e1e909: [services][backup] Remove old C++ implementation (authored by bartek). · Explain WhyJan 23 2023, 6:01 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMaf2470e1e909: [services][backup] Remove old C++ implementation.

Revision Contents
Changeset List

Diff 21120

View Options

.gitignore

Loading...
View Options

services/backup/old/CMakeLists.txt

Loading...
View Options

services/backup/old/blob_client/Cargo.lock

Loading...
View Options

services/backup/old/blob_client/Cargo.toml

Loading...
View Options

services/backup/old/blob_client/build.rs

Loading...
View Options

services/backup/old/blob_client/src/constants.rs

Loading...
View Options

services/backup/old/blob_client/src/get_client.rs

Loading...
View Options

services/backup/old/blob_client/src/lib.rs

Loading...
View Options

services/backup/old/blob_client/src/put_client.rs

Loading...
View Options

services/backup/old/src/BackupServiceImpl.h

Loading...
View Options

services/backup/old/src/BackupServiceImpl.cpp

Loading...
View Options

services/backup/old/src/Constants.h

Loading...
View Options

services/backup/old/src/DatabaseEntities/BackupItem.h

Loading...
View Options

services/backup/old/src/DatabaseEntities/BackupItem.cpp

Loading...
View Options

services/backup/old/src/DatabaseEntities/LogItem.h

Loading...
View Options

services/backup/old/src/DatabaseEntities/LogItem.cpp

Loading...
View Options

services/backup/old/src/DatabaseManager.h

Loading...
View Options

services/backup/old/src/DatabaseManager.cpp

Loading...
View Options

services/backup/old/src/Reactors/server/AddAttachmentsUtility.h

Loading...
View Options

services/backup/old/src/Reactors/server/AddAttachmentsUtility.cpp

Loading...
View Options

services/backup/old/src/Reactors/server/CreateNewBackupReactor.h

Loading...
View Options

services/backup/old/src/Reactors/server/CreateNewBackupReactor.cpp

Loading...
View Options

services/backup/old/src/Reactors/server/PullBackupReactor.h

Loading...
View Options

services/backup/old/src/Reactors/server/PullBackupReactor.cpp

Loading...
View Options

services/backup/old/src/Reactors/server/RecoverBackupKeyReactor.h

Loading...
View Options

services/backup/old/src/Reactors/server/SendLogReactor.h

Loading...
View Options

services/backup/old/src/Reactors/server/SendLogReactor.cpp

Loading...
View Options

services/backup/old/src/Tools.h

Loading...
View Options

services/backup/old/src/Tools.cpp

Loading...
View Options

services/backup/old/src/server.cpp

Loading...
View Options

services/backup/old/test/BackupTest.cpp

Loading...
View Options

services/backup/old/test/DatabaseManagerTest.cpp

Loading...