[web] Add modals for updating the desktop app
ClosedPublic
Actions

Authored by michal on Jan 20 2023, 4:18 AM.

Details

Reviewers

Commits

Summary

Adds modals for updating the desktop app. There are two cases:

The user is using the first version of the app. We check if the version string exists and if not, we prompt the user to download manually a new (self-updating) version. This is shown on refresh.
If the user is on the self-updating version, after downloading the new version we ask if they want to restart the app

(both of them only show up when it's the desktop app not the web app)

Test Plan

Check if the user is prompted to download the new version if there is no version string
Check if the user is prompted to restart after a new version is available and the update is applied correctly

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

michal requested review of this revision.Jan 20 2023, 4:32 AM

Some questions

web/modals/update-modal.react.js
46 ↗	(On Diff #21142)	We should add a comment explaining that this is only for the first upgrade
50 ↗	(On Diff #21142)	How do we avoid showing this if the user has downloaded the new version?
74 ↗	(On Diff #21142)	Is it possible for multiple handlers to be set if `pushModal` is changed? Should we return a cleanup function from this effect to remove the old handler when that happens?

This revision now requires changes to proceed.Jan 20 2023, 10:41 AM

Add comment

web/modals/update-modal.react.js
50 ↗	(On Diff #21142)	The `version` property isn't available on old versions. So in the newer versions, the second part of the condition will return.
74 ↗	(On Diff #21142)	This already happens, you can see the cleanup function in D6322 in preload.js:17.