Paths

Table of Contentst

Differential D6396

[native] Don't crash if Alchemy API key is missing
ClosedPublic
Actions

Authored by ashoat on Jan 26 2023, 5:00 PM.

Tags

None

Referenced Files

None

Subscribers

None

Details

Reviewers

kamil
• przemek
atul
ginsu
marcin
tomek

Commits

rCOMMbde0aad9e5ec: [native] Don't crash if Alchemy API key is missing

Summary

This fixes ENG-2836. I should've tested this scenario before landing D6373. The docs seemed to indicate that the Alchemy API key was optional, and I know Wagmi "works" without it. But now I think it's only optional for Ethers.js for testnet or something?

Test Plan

Confirm crash no longer occurs when Alchemy API key is missing (no native/facts/alchemy.json file) in native app

Diff Detail

Repository

Branch

ashoat/fix_ethers_crash

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jan 26 2023, 5:00 PM

Harbormaster completed remote builds in B15674: Diff 21373.Jan 26 2023, 5:14 PM

ashoat requested review of this revision.Jan 26 2023, 5:14 PM

tomek accepted this revision.Jan 26 2023, 5:25 PM

This revision is now accepted and ready to land.Jan 26 2023, 5:25 PM

Closed by commit rCOMMbde0aad9e5ec: [native] Don't crash if Alchemy API key is missing. · Explain WhyJan 26 2023, 5:35 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMbde0aad9e5ec: [native] Don't crash if Alchemy API key is missing.

Revision Contents
Changeset List

Path

Size

lib/

components/

ens-cache-provider.react.js

4 lines

native/

utils/

ethers-utils.js

8 lines

Diff 21373

lib/components/ens-cache-provider.react.js

Loading...

native/utils/ethers-utils.js

Loading...