Page MenuHomePhabricator
Differential D6414

Remove react-native-firebase dependency from the project
ClosedPublic
Actions

Authored by marcin on Jan 27 2023, 4:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 3:50 AM
Unknown Object (File)
Sat, Dec 14, 3:50 AM
Unknown Object (File)
Sat, Dec 14, 3:50 AM
Unknown Object (File)
Sat, Dec 14, 3:50 AM
Unknown Object (File)
Sat, Dec 14, 3:50 AM
Unknown Object (File)
Sat, Dec 14, 3:50 AM
Unknown Object (File)
Sat, Dec 14, 3:40 AM
Unknown Object (File)
Tue, Dec 3, 7:08 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
bartek
ashoat
Commits
rCOMM1201191214c9: Remove react-native-firebase dependency from the project
Summary

This differential removes react-native-firebase dependency from the project

Test Plan

Build the app. Repeat test plans for other differentials in this stack to ensure notifications functionality works correctly - there are no other usages of this library in the project this diff stack didn't remove

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2501
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jan 27 2023, 4:04 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 27 2023, 4:04 AM
marcin added a parent revision: D6381: Implement native method to get device token and use it in JavaScript.Jan 27 2023, 4:05 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 27 2023, 4:06 AM
Harbormaster failed remote builds in B15717: Diff 21437!
marcin updated this revision to Diff 21438.Jan 27 2023, 4:12 AM

Remove:

  • react-native-firebase patch
  • firebase.js file
  • react-native-firebase from flowconfig -
Harbormaster completed remote builds in B15718: Diff 21438.Jan 27 2023, 4:26 AM
marcin requested review of this revision.Jan 27 2023, 4:26 AM
ashoat added a comment.Jan 27 2023, 4:54 AM

Really exciting!!

ashoat accepted this revision.Jan 27 2023, 4:54 AM
This revision is now accepted and ready to land.Jan 27 2023, 4:54 AM
marcin updated this revision to Diff 21461.Jan 27 2023, 6:43 AM

Rebase before landing

Harbormaster completed remote builds in B15740: Diff 21461.Jan 27 2023, 7:04 AM
marcin updated this revision to Diff 21577.Jan 30 2023, 3:13 AM

Rebase before landing

Harbormaster completed remote builds in B15831: Diff 21577.Jan 30 2023, 3:35 AM
Closed by commit rCOMM1201191214c9: Remove react-native-firebase dependency from the project (authored by marcin). · Explain WhyJan 30 2023, 4:12 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM1201191214c9: Remove react-native-firebase dependency from the project.

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
main/
java/
app/
comm/
android/
4 lines
1 line
13 lines

Diff 21437

View Options

native/android/app/src/main/java/app/comm/android/MainApplication.java

Loading...
View Options

native/package.json

Loading...
View Options

native/react-native.config.js

Loading...
View Options

yarn.lock

Loading...