Page MenuHomePhabricator
Differential D6414

Remove react-native-firebase dependency from the project
ClosedPublic
Actions

Authored by marcin on Jan 27 2023, 4:04 AM.
Tags
None
Referenced Files
F3249534: D6414.diff
Fri, Nov 15, 3:50 PM
Unknown Object (File)
Mon, Nov 4, 3:16 AM
Unknown Object (File)
Sat, Oct 26, 8:45 PM
Unknown Object (File)
Fri, Oct 18, 9:06 PM
Unknown Object (File)
Thu, Oct 17, 10:43 AM
Unknown Object (File)
Oct 6 2024, 3:15 PM
Unknown Object (File)
Oct 1 2024, 5:00 AM
Unknown Object (File)
Sep 29 2024, 8:53 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
bartek
ashoat
Commits
rCOMM1201191214c9: Remove react-native-firebase dependency from the project
Summary

This differential removes react-native-firebase dependency from the project

Test Plan

Build the app. Repeat test plans for other differentials in this stack to ensure notifications functionality works correctly - there are no other usages of this library in the project this diff stack didn't remove

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Jan 27 2023, 4:04 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 27 2023, 4:04 AM
marcin added a parent revision: D6381: Implement native method to get device token and use it in JavaScript.Jan 27 2023, 4:05 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 27 2023, 4:06 AM
Harbormaster failed remote builds in B15717: Diff 21437!
marcin updated this revision to Diff 21438.Jan 27 2023, 4:12 AM

Remove:

  • react-native-firebase patch
  • firebase.js file
  • react-native-firebase from flowconfig -
Harbormaster completed remote builds in B15718: Diff 21438.Jan 27 2023, 4:26 AM
marcin requested review of this revision.Jan 27 2023, 4:26 AM
ashoat added a comment.Jan 27 2023, 4:54 AM

Really exciting!!

ashoat accepted this revision.Jan 27 2023, 4:54 AM
This revision is now accepted and ready to land.Jan 27 2023, 4:54 AM
marcin updated this revision to Diff 21461.Jan 27 2023, 6:43 AM

Rebase before landing

Harbormaster completed remote builds in B15740: Diff 21461.Jan 27 2023, 7:04 AM
marcin updated this revision to Diff 21577.Jan 30 2023, 3:13 AM

Rebase before landing

Harbormaster completed remote builds in B15831: Diff 21577.Jan 30 2023, 3:35 AM
Closed by commit rCOMM1201191214c9: Remove react-native-firebase dependency from the project (authored by marcin). · Explain WhyJan 30 2023, 4:12 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM1201191214c9: Remove react-native-firebase dependency from the project.

Revision Contents
Changeset List

PathSize
native/
1 line
android/
app/
src/
main/
java/
app/
comm/
android/
4 lines
1 line
push/
patches/
13 lines

Diff 21604

View Options

native/.flowconfig

Loading...
View Options

native/android/app/src/main/java/app/comm/android/MainApplication.java

Loading...
View Options

native/package.json

Loading...
View Options

native/push/firebase.js

Loading...
View Options

native/react-native.config.js

Loading...
View Options

patches/react-native-firebase+5.6.0.patch

Loading...
View Options

yarn.lock

Loading...