Page MenuHomePhabricator
Differential D6462

[web] Add logic for displaying only chats from a given community in calendar filters
ClosedPublic
Actions

Authored by inka on Jan 30 2023, 5:52 AM.
Tags
None
Referenced Files
F3499483: D6462.diff
Thu, Dec 19, 11:21 PM
Unknown Object (File)
Thu, Dec 12, 4:01 AM
Unknown Object (File)
Wed, Dec 11, 9:18 PM
Unknown Object (File)
Thu, Dec 5, 10:56 PM
Unknown Object (File)
Sat, Nov 30, 6:09 AM
Unknown Object (File)
Sat, Nov 30, 5:56 AM
Unknown Object (File)
Sat, Nov 30, 5:43 AM
Unknown Object (File)
Sat, Nov 30, 5:43 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
kamil
tomek
Commits
rCOMMa0de81075309: [web] Add logic for displaying only chats from a given community in calendar…
Summary

issue: https://linear.app/comm/issue/ENG-2794/make-it-possible-to-display-only-chats-from-a-given-community-in-the
Add to FilterPanel logic, that will allow to display only chats of a given community in filters.

Test Plan

Checked that when a community is chosen it is not possible to add an event for a chat from a different community - ThreadPickedModal displays only chats from this community. Checked that only chats fro the give community show up in the filter panel.
Check that the square next to the "Your chats" button is filled when all chats from the picked community are selected. Not only when all chats the user is a member of are selected.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jan 30 2023, 5:52 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 30 2023, 5:52 AM
inka added a parent revision: D6461: [web] Add a selector fetching thread IDs according to COMMUNITIES calendar filter.Jan 30 2023, 5:53 AM
inka updated this revision to Diff 21611.Jan 30 2023, 6:03 AM

Fix filter panel not updating when community is picek and a search query is typed in / when a search query is typed in and a community gets picked

Harbormaster completed remote builds in B15844: Diff 21609.Jan 30 2023, 6:06 AM
Harbormaster completed remote builds in B15846: Diff 21611.Jan 30 2023, 6:17 AM
inka requested review of this revision.Jan 30 2023, 6:17 AM
inka updated this revision to Diff 22113.Feb 6 2023, 2:12 AM

Rebase

Harbormaster completed remote builds in B16163: Diff 22113.Feb 6 2023, 2:48 AM
inka updated this revision to Diff 22177.Feb 7 2023, 3:48 AM

Changes due to changes in previous diffs

Harbormaster completed remote builds in B16212: Diff 22177.Feb 7 2023, 4:03 AM
inka updated this revision to Diff 22183.Feb 7 2023, 5:02 AM

Rebase

Harbormaster completed remote builds in B16218: Diff 22183.Feb 7 2023, 5:16 AM
inka updated this revision to Diff 22184.Feb 7 2023, 6:31 AM

Actually clearCalendarCommunityFilter and updateCalendarCommunityFilter actions will be dispatched from outsied of the filter panel

inka added a child revision: D6646: [web] Make pressing a drawer item in calendar tab change available filters.Feb 7 2023, 6:39 AM
Harbormaster completed remote builds in B16219: Diff 22184.Feb 7 2023, 6:46 AM
inka updated this revision to Diff 22188.Feb 7 2023, 7:08 AM

Fix onToggleAll

Harbormaster completed remote builds in B16223: Diff 22188.Feb 7 2023, 7:21 AM
inka edited the summary of this revision. (Show Details)Feb 8 2023, 2:16 AM
inka edited the test plan for this revision. (Show Details)
inka added inline comments.Feb 8 2023, 2:19 AM
web/calendar/filter-panel.react.js
94–98 ↗(On Diff #22188)

We want the square next to the "Your chats" button to be filled when all chats from the picked community are selected. Not only when all chats the user is a member of are selected.

199–201 ↗(On Diff #22188)

When a community is picked, we want pressing the "Your chats" button to pick / unpick only chats from this community

kamil accepted this revision.Feb 8 2023, 8:36 AM
kamil added inline comments.
web/calendar/filter-panel.react.js
94–98 ↗(On Diff #22188)

Could you amend this to the test plan?

This revision is now accepted and ready to land.Feb 8 2023, 8:36 AM
inka added a parent revision: D6645: [web] Add to calendar filters reducer logic for handling the COMMUNITY filters.Feb 9 2023, 1:12 AM
inka removed a parent revision: D6461: [web] Add a selector fetching thread IDs according to COMMUNITIES calendar filter.
inka edited the test plan for this revision. (Show Details)Feb 9 2023, 1:21 AM
inka edited the test plan for this revision. (Show Details)
inka added 1 blocking reviewer(s): tomek.Feb 9 2023, 1:36 AM
This revision now requires review to proceed.Feb 9 2023, 1:36 AM
tomek requested changes to this revision.Feb 9 2023, 4:53 AM

Overall looks good, but there are a couple of minor comments and I would like to see this code after the changes are applied.

web/calendar/filter-panel.react.js
72–75 ↗(On Diff #22188)

This can be simplified, but you don't have to do that if you think that the simplified version is less readable

79–84 ↗(On Diff #22188)

Mutating a variable is usually reducing the maintainability. Can we avoid this by introducing a new name instead of reassigning?

199–202 ↗(On Diff #22188)

We can optimize this a bit by avoiding the conversion to an array when the value is not being used (when !value)

This revision now requires changes to proceed.Feb 9 2023, 4:53 AM
inka added inline comments.Feb 9 2023, 5:59 AM
web/calendar/filter-panel.react.js
72–75 ↗(On Diff #22188)

I'd prefer to keep it as it is. It's also consistent with the function right above.

inka updated this revision to Diff 22295.Feb 9 2023, 5:59 AM
inka edited the summary of this revision. (Show Details)

Address code review

inka planned changes to this revision.Feb 9 2023, 6:02 AM
Harbormaster completed remote builds in B16295: Diff 22295.Feb 9 2023, 6:14 AM
inka requested review of this revision.Feb 9 2023, 7:26 AM
inka updated this revision to Diff 22298.Feb 9 2023, 8:14 AM

Rebase

tomek accepted this revision.Feb 9 2023, 8:14 AM
This revision is now accepted and ready to land.Feb 9 2023, 8:14 AM
Harbormaster completed remote builds in B16298: Diff 22298.Feb 9 2023, 8:29 AM
inka updated this revision to Diff 22394.Feb 13 2023, 12:15 AM

Rebase

Harbormaster completed remote builds in B16366: Diff 22394.Feb 13 2023, 12:29 AM
inka updated this revision to Diff 22458.Feb 13 2023, 7:21 AM

Rebase

Harbormaster failed remote builds in B16421: Diff 22458!Feb 13 2023, 7:38 AM
inka updated this revision to Diff 22472.Feb 13 2023, 8:22 AM

Add .js to imports

Updating D6462: [web] Add logic for displaying only chats from a given community in calendar filters # # Enter a brief description of the changes included in this update. # The first line is used as subject, next lines as comment. # # If

you intended to create a new revision, use: # $ arc diff --create

inka updated this revision to Diff 22476.Feb 13 2023, 8:42 AM

Remove accidental changes

inka updated this revision to Diff 22479.Feb 13 2023, 9:08 AM

Trying to fix my local copy

Harbormaster completed remote builds in B16435: Diff 22472.Feb 13 2023, 9:45 AM
Harbormaster completed remote builds in B16439: Diff 22476.Feb 13 2023, 9:56 AM
Harbormaster completed remote builds in B16442: Diff 22479.Feb 13 2023, 10:05 AM
inka updated this revision to Diff 22546.Feb 14 2023, 2:42 AM

Rebase

Harbormaster completed remote builds in B16499: Diff 22546.Feb 14 2023, 3:54 AM
Closed by commit rCOMMa0de81075309: [web] Add logic for displaying only chats from a given community in calendar… (authored by • InkaSokolowska). · Explain WhyFeb 14 2023, 5:02 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMMa0de81075309: [web] Add logic for displaying only chats from a given community in calendar….

Revision Contents
Changeset List

PathSize
web/
calendar/
57 lines
sidebar/
26 lines

Diff 22472

View Options

web/calendar/filter-panel.react.js

Loading...
View Options

web/sidebar/community-drawer-item-handlers.react.js

Loading...