Page MenuHomePhabricator

[Android] Promote folly to library target
ClosedPublic

Authored by jon on Jan 31 2023, 10:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 4:54 PM
Unknown Object (File)
Thu, Mar 21, 12:19 AM
Unknown Object (File)
Tue, Mar 12, 11:42 PM
Unknown Object (File)
Tue, Mar 12, 11:42 PM
Unknown Object (File)
Tue, Mar 12, 11:42 PM
Unknown Object (File)
Tue, Mar 12, 11:42 PM
Unknown Object (File)
Tue, Mar 12, 11:42 PM
Unknown Object (File)
Feb 22 2024, 1:40 PM
Subscribers

Details

Summary

Other CMake modules in native/cpp also need folly, so
we need to have folly as a well defined target which those files
can consume.

https://linear.app/comm/issue/ENG-2895

Test Plan

Android gate passes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 31 2023, 10:43 AM
Harbormaster failed remote builds in B15896: Diff 21697!

Remove obsolete references to folly dependencies

This revision is now accepted and ready to land.Feb 1 2023, 8:01 AM
This revision was automatically updated to reflect the committed changes.