Page MenuHomePhabricator

[Android] Refactor openssl code to separate file and target
ClosedPublic

Authored by jon on Feb 13 2023, 11:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 2:09 PM
Unknown Object (File)
Mon, Mar 25, 2:09 PM
Unknown Object (File)
Mon, Mar 25, 2:09 PM
Unknown Object (File)
Mon, Mar 25, 2:09 PM
Unknown Object (File)
Mon, Mar 25, 2:09 PM
Unknown Object (File)
Sat, Mar 16, 3:05 AM
Unknown Object (File)
Tue, Feb 27, 6:29 PM
Unknown Object (File)
Feb 22 2024, 1:20 PM
Subscribers

Details

Summary

CommonCpp/DatabaseManagers also makes use of sqlite +
openssl, refactor the logic so that the related openssl gets
moved to it's own file.

https://linear.app/comm/issue/ENG-3002

Depends on D6621

Test Plan

Android gate passes.

Local dev workflow also works:

# start keyserver and native
(cd keyserver && yarn dev &)
(cd native && yarn dev &)

cd native && yarn react-native run-android

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 13 2023, 11:10 AM
Harbormaster failed remote builds in B16455: Diff 22496!

Thanks for including testing Android in the test plan!

Let's chat about prioritization of this work tomorrow – I was under the impression we were pausing for the time being, but understand you might just be putting up some code you had already worked on

I had already done the work in my attempt to get the jni working for the native modules

This revision is now accepted and ready to land.Feb 14 2023, 10:35 AM

Happy to land this now, but let's discuss tomorrow RE ways to reduce JNI boilerplate for devs