Page MenuHomePhabricator
Differential D6721

[Android] Refactor openssl code to separate file and target
ClosedPublic
Actions

Authored by • jon on Feb 13 2023, 11:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 11:17 PM
Unknown Object (File)
Fri, Nov 1, 8:18 AM
Unknown Object (File)
Fri, Nov 1, 8:14 AM
Unknown Object (File)
Fri, Nov 1, 8:13 AM
Unknown Object (File)
Fri, Nov 1, 8:13 AM
Unknown Object (File)
Fri, Nov 1, 7:57 AM
Unknown Object (File)
Tue, Oct 29, 7:52 AM
Unknown Object (File)
Tue, Oct 29, 7:52 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
• max
atul
Commits
rCOMM72905906676f: [Android] Refactor openssl code to separate file and target
Summary

CommonCpp/DatabaseManagers also makes use of sqlite +
openssl, refactor the logic so that the related openssl gets
moved to it's own file.

https://linear.app/comm/issue/ENG-3002

Depends on D6621

Test Plan

Android gate passes.

Local dev workflow also works:

# start keyserver and native
(cd keyserver && yarn dev &)
(cd native && yarn dev &)

cd native && yarn react-native run-android

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Feb 13 2023, 11:08 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 13 2023, 11:08 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 13 2023, 11:10 AM
Harbormaster failed remote builds in B16455: Diff 22496!
• jon added a child revision: D6722: [Android] Reference Tools by CMake project.Feb 13 2023, 11:38 AM
• jon updated this revision to Diff 22503.Feb 13 2023, 12:11 PM

Lint

Harbormaster completed remote builds in B16459: Diff 22503.Feb 13 2023, 12:27 PM
• jon requested review of this revision.Feb 13 2023, 12:27 PM
ashoat added a comment.EditedFeb 13 2023, 4:03 PM

Thanks for including testing Android in the test plan!

Let's chat about prioritization of this work tomorrow – I was under the impression we were pausing for the time being, but understand you might just be putting up some code you had already worked on

• jon added a comment.Feb 13 2023, 5:11 PM

I had already done the work in my attempt to get the jni working for the native modules

atul accepted this revision.Feb 14 2023, 10:35 AM
This revision is now accepted and ready to land.Feb 14 2023, 10:35 AM
ashoat added a comment.Feb 15 2023, 7:16 AM

Happy to land this now, but let's discuss tomorrow RE ways to reduce JNI boilerplate for devs

• max accepted this revision.Feb 15 2023, 3:51 PM
Closed by commit rCOMM72905906676f: [Android] Refactor openssl code to separate file and target (authored by • jon). · Explain WhyFeb 20 2023, 6:29 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM72905906676f: [Android] Refactor openssl code to separate file and target.

Revision Contents
Changeset List

PathSize
native/
android/
app/
32 lines
cmake/
29 lines

Diff 22496

View Options

native/android/app/CMakeLists.txt

Loading...
View Options

native/android/app/cmake/openssl-target.cmake

Loading...