Page MenuHomePhabricator
Differential D6498

[Native] Remove CMake installation logic from native/cpp
ClosedPublic
Actions

Authored by • jon on Feb 1 2023, 12:17 PM.
Tags
None
Referenced Files
F3347203: D6498.diff
Fri, Nov 22, 11:18 AM
Unknown Object (File)
Mon, Nov 18, 8:56 PM
Unknown Object (File)
Thu, Nov 14, 12:56 PM
Unknown Object (File)
Fri, Nov 8, 1:31 AM
Unknown Object (File)
Fri, Nov 1, 9:22 AM
Unknown Object (File)
Fri, Nov 1, 9:21 AM
Unknown Object (File)
Fri, Nov 1, 9:21 AM
Unknown Object (File)
Fri, Nov 1, 8:13 AM
View All 69 Files
Subscribers
tomek

Details

Reviewers
• max
ashoat
varun
atul
Commits
rCOMM942f509f745c: [Native] Remove CMake installation logic from native/cpp
Summary

Not strictly needed since we don't install the
native cpp modules separately.

add_subdirectory was added to android/app/CMakeLists.txt
to ensure that the CMake logic is compatible.

Depends on D6484

Test Plan

Android gate passes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Feb 1 2023, 12:17 PM
Herald added a subscriber: tomek. · View Herald TranscriptFeb 1 2023, 12:17 PM
Harbormaster completed remote builds in B15948: Diff 21780.Feb 1 2023, 12:34 PM
• jon requested review of this revision.Feb 1 2023, 12:34 PM
ashoat accepted this revision.Feb 1 2023, 1:06 PM
ashoat added inline comments.
native/android/app/CMakeLists.txt
107–113 ↗(On Diff #21780)

Will the add_subdirectory conflict at all with these lines?

This revision is now accepted and ready to land.Feb 1 2023, 1:06 PM
• jon marked an inline comment as done.Feb 1 2023, 2:01 PM
• jon added inline comments.
native/android/app/CMakeLists.txt
107–113 ↗(On Diff #21780)

No, it just reads the cmake files, but shouldn't affect the libcomm-jni that we produce.

• jon added a child revision: D6507: [Android] Use native modules from CMake.Feb 1 2023, 2:02 PM
• jon added a child revision: D6621: [CMake] Resolve rust library include directory.Feb 5 2023, 6:26 PM
• jon removed a child revision: D6507: [Android] Use native modules from CMake.Feb 5 2023, 6:26 PM
Closed by commit rCOMM942f509f745c: [Native] Remove CMake installation logic from native/cpp (authored by • jon). · Explain WhyFeb 6 2023, 7:22 AM
This revision was automatically updated to reflect the committed changes.
• jon marked an inline comment as done.
• jon added a commit: rCOMM942f509f745c: [Native] Remove CMake installation logic from native/cpp.

Revision Contents
Changeset List

PathSize
native/
android/
app/
5 lines
cpp/
CommonCpp/
CryptoTools/
23 lines
DatabaseManagers/
22 lines
NativeModules/
30 lines
Tools/
22 lines

Diff 22129

View Options

native/android/app/CMakeLists.txt

Loading...
View Options

native/cpp/CommonCpp/CryptoTools/CMakeLists.txt

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/CMakeLists.txt

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CMakeLists.txt

Loading...
View Options

native/cpp/CommonCpp/Tools/CMakeLists.txt

Loading...