Paths

Table of Contentst

[lib] Use pluralize in robotextForUsers
ClosedPublic
Actions

Authored by ashoat on Feb 1 2023, 2:05 PM.

Tags

None

Referenced Files

	F3293520: D6510.diff
	Sat, Nov 16, 5:25 PM

	Unknown Object (File)
	Thu, Nov 14, 8:17 PM

	Unknown Object (File)
	Sat, Oct 26, 9:22 PM

	Unknown Object (File)
	Sat, Oct 26, 9:22 PM

	Unknown Object (File)
	Sat, Oct 26, 9:21 PM

	Unknown Object (File)
	Sat, Oct 26, 9:14 PM

	Unknown Object (File)
	Sep 26 2024, 8:39 AM

	Unknown Object (File)
	Sep 26 2024, 8:39 AM

View All 85 Files

Subscribers

tomek

Details

Reviewers

atul

Commits

rCOMM216451b11dd9: [lib] Use pluralize in robotextForUsers

Summary

Seems like this code is just duplicated. I checked the unit tests for pluralize and they seem to do exactly what we want here.

Test Plan

Played around with robotext messages and they all look right

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 1 2023, 2:05 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 1 2023, 2:05 PM

ashoat added a parent revision: D6509: [lib] Add helpers for EntityText.Feb 1 2023, 2:06 PM

ashoat added a child revision: D6511: [lib] Introduce basePluralize.Feb 1 2023, 2:07 PM

Harbormaster completed remote builds in B15969: Diff 21805.Feb 1 2023, 2:21 PM

ashoat requested review of this revision.Feb 1 2023, 2:21 PM

Nice

This revision is now accepted and ready to land.Feb 2 2023, 10:42 AM

Closed by commit rCOMM216451b11dd9: [lib] Use pluralize in robotextForUsers (authored by ashoat). · Explain WhyFeb 2 2023, 11:41 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM216451b11dd9: [lib] Use pluralize in robotextForUsers.

Revision Contents
Changeset List

Path

Size

lib/

shared/

message-utils.js

17 lines

Diff 21805

View Options

lib/shared/message-utils.js

[lib] Use pluralize in robotextForUsersClosedPublicActions