Paths

Table of Contentst

Differential D6578

[lib] Migrate CreateThread/CreateSubThread notifTexts to use EntityText
ClosedPublic
Actions

Authored by ashoat on Feb 4 2023, 10:03 AM.

Tags

None

Referenced Files

	F2174965: D6578.diff
	Wed, Jul 3, 1:37 AM

	Unknown Object (File)
	Thu, Jun 27, 4:29 PM

	Unknown Object (File)
	Thu, Jun 27, 4:29 PM

	Unknown Object (File)
	Thu, Jun 27, 4:28 PM

	Unknown Object (File)
	Thu, Jun 27, 4:24 PM

	Unknown Object (File)
	Wed, Jun 12, 10:30 AM

	Unknown Object (File)
	Tue, Jun 11, 8:34 AM

	Unknown Object (File)
	Fri, Jun 7, 9:16 PM

View All 42 Files

Subscribers

Details

Reviewers

Commits

rCOMM529a65b1cfc5: [lib] Migrate CreateThread/CreateSubThread notifTexts to use EntityText

Summary

Note that this introduces a require cycle by having message specs import directly from notif-utils, which imports into them. I think it's fine in modern Node.js.

Depends on D6577

Test Plan

Generated CreateThread and CreateSubThread messages on a web client in a chat with a different test user that is logged in on the iOS simulator. Background the iOS app and make sure the notif looks right

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 4 2023, 10:03 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 4 2023, 10:03 AM

ashoat added a child revision: D6579: [lib] Migrate CreateSidebar notifText to use EntityText.Feb 4 2023, 10:04 AM

Harbormaster completed remote builds in B16092: Diff 21984.Feb 4 2023, 12:15 PM

ashoat requested review of this revision.Feb 4 2023, 12:15 PM

atul accepted this revision.Feb 4 2023, 2:22 PM

This revision is now accepted and ready to land.Feb 4 2023, 2:22 PM

Closed by commit rCOMM529a65b1cfc5: [lib] Migrate CreateThread/CreateSubThread notifTexts to use EntityText (authored by ashoat). · Explain WhyFeb 5 2023, 8:01 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM529a65b1cfc5: [lib] Migrate CreateThread/CreateSubThread notifTexts to use EntityText.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

create-sub-thread-message-spec.js

17 lines

create-thread-message-spec.js

35 lines

message-spec.js

9 lines

41 lines

Diff 22059

lib/shared/messages/create-sub-thread-message-spec.js

Loading...

lib/shared/messages/create-thread-message-spec.js

Loading...

lib/shared/messages/message-spec.js

Loading...

lib/shared/notif-utils.js

Loading...