Tags

None

Referenced Files

	F2846819: D6580.diff
	Mon, Sep 30, 12:23 AM

	Unknown Object (File)
	Thu, Sep 26, 8:19 AM

	Unknown Object (File)
	Thu, Sep 26, 8:19 AM

	Unknown Object (File)
	Thu, Sep 26, 8:19 AM

	Unknown Object (File)
	Thu, Sep 26, 8:13 AM

	Unknown Object (File)
	Mon, Sep 9, 4:11 PM

	Unknown Object (File)
	Mon, Sep 2, 6:37 AM

	Unknown Object (File)
	Sat, Aug 31, 12:56 AM

View All 62 Files

Subscribers

tomek

Details

Reviewers

atul

Commits

rCOMMa81600924de6: [lib] Migrate JoinThread/LeaveThread notifTexts to use EntityText

Summary

Depends on D6579

Test Plan

Generated JoinThread and LeaveThread messages on a web client in a chat with a different test user that is logged in on the iOS simulator. Background the iOS app and make sure the notif looks right

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 4 2023, 10:04 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 4 2023, 10:04 AM

ashoat added a child revision: D6581: [lib] Migrate Text notifText to use EntityText.Feb 4 2023, 10:05 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 4 2023, 10:14 AM

Harbormaster failed remote builds in B16094: Diff 21986!

Harbormaster completed remote builds in B16094: Diff 21986.Feb 4 2023, 10:38 AM

ashoat requested review of this revision.Feb 4 2023, 10:38 AM

atul accepted this revision.Feb 4 2023, 11:58 AM

This revision is now accepted and ready to land.Feb 4 2023, 11:58 AM

Closed by commit rCOMMa81600924de6: [lib] Migrate JoinThread/LeaveThread notifTexts to use EntityText (authored by ashoat). · Explain WhyFeb 5 2023, 8:01 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMa81600924de6: [lib] Migrate JoinThread/LeaveThread notifTexts to use EntityText.

[lib] Migrate JoinThread/LeaveThread notifTexts to use EntityText
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 22061

lib/shared/messages/join-thread-message-spec.js

lib/shared/messages/leave-thread-message-spec.js

[lib] Migrate JoinThread/LeaveThread notifTexts to use EntityTextClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22061

lib/shared/messages/join-thread-message-spec.js

lib/shared/messages/leave-thread-message-spec.js

[lib] Migrate JoinThread/LeaveThread notifTexts to use EntityText
ClosedPublic
Actions

Revision Contents
Changeset List