Page MenuHomePhabricator
Differential D6636

[web] Replace RainbowKit `ConnectButton` with `ConnectedWalletInfo`
ClosedPublic
Actions

Authored by atul on Feb 6 2023, 12:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 1:08 AM
Unknown Object (File)
Mon, Nov 11, 6:47 PM
Unknown Object (File)
Mon, Nov 11, 1:56 PM
Unknown Object (File)
Mon, Nov 11, 11:51 AM
Unknown Object (File)
Mon, Nov 11, 12:30 AM
Unknown Object (File)
Sun, Nov 10, 11:50 PM
Unknown Object (File)
Sun, Nov 10, 11:24 PM
Unknown Object (File)
Sun, Nov 10, 9:25 PM
View All 73 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
ginsu
rohan
Commits
rCOMM983741bf9b5f: [web] Replace RainbowKit `ConnectButton` with `ConnectedWalletInfo`
Summary

We kept ConnectButton around just to be able to check ConnectedWalletInfo against it, but now we can just remove since ConnectedWalletInfo is pretty much there. (Last thing is ENS avatars where it should be obvious if it's displayed or not)

Depends on D6635

Test Plan

Looks as expected:

a3fe8b.png (1×906 px, 131 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Feb 6 2023, 12:56 PM
atul published this revision for review.Feb 6 2023, 12:58 PM
atul edited the test plan for this revision. (Show Details)
atul updated this revision to Diff 22155.Feb 6 2023, 12:58 PM

update padding-bottom value

atul edited the summary of this revision. (Show Details)Feb 6 2023, 12:59 PM
atul added reviewers: ginsu, rohan.
Harbormaster completed remote builds in B16190: Diff 22154.Feb 6 2023, 1:08 PM
Harbormaster completed remote builds in B16191: Diff 22155.Feb 6 2023, 1:14 PM
atul added a child revision: D6637: [web] Add ENSAvatar to `ConnectedWalletInfo` if set.Feb 6 2023, 1:29 PM
atul edited the summary of this revision. (Show Details)Feb 6 2023, 5:54 PM
atul added a parent revision: D6635: [web] Add `shortenAddressToFitWidth` to `ConnectedWalletInfo`.
ashoat accepted this revision.Feb 6 2023, 5:56 PM
This revision is now accepted and ready to land.Feb 6 2023, 5:56 PM
atul updated this revision to Diff 22195.Feb 7 2023, 8:57 AM

land + rebase

This revision was landed with ongoing or failed builds.Feb 7 2023, 8:58 AM
Closed by commit rCOMM983741bf9b5f: [web] Replace RainbowKit `ConnectButton` with `ConnectedWalletInfo` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM983741bf9b5f: [web] Replace RainbowKit `ConnectButton` with `ConnectedWalletInfo`.
Harbormaster completed remote builds in B16228: Diff 22195.Feb 7 2023, 9:12 AM

Revision Contents
Changeset List

PathSize
web/
account/
8 lines
11 lines

Diff 22196

View Options

web/account/siwe-login-form.react.js

Loading...
View Options

web/account/siwe.css

Loading...