Page MenuHomePhabricator
Differential D6638

[lib] Move `SWMansion.react` to `lib` so it can be shared across `web` and `landing`
ClosedPublic
Actions

Authored by atul on Feb 6 2023, 2:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 11:32 PM
Unknown Object (File)
Sun, Nov 10, 10:59 PM
Unknown Object (File)
Sun, Nov 10, 10:56 PM
Unknown Object (File)
Sun, Nov 10, 10:46 PM
Unknown Object (File)
Sun, Nov 10, 1:50 PM
Unknown Object (File)
Thu, Nov 7, 8:54 AM
Unknown Object (File)
Sep 29 2024, 10:32 PM
Unknown Object (File)
Sep 17 2024, 9:49 PM
View All 66 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
ginsu
rohan
Commits
rCOMM8897f461be7b: [lib] Move `SWMansion.react` to `lib` so it can be shared across `web` and…
Summary

So we can move ConnectedWalletInfo in a subsequent diff... plus it just makes sense for this to be shared.

Depends on D6637

Test Plan

We will see if web continues to look right after moving SWMansion.react component to lib.

EDIT: Things continue to look as expected:

5df414.png (2×2 px, 294 KB)

190691.png (2×3 px, 436 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Feb 6 2023, 2:12 PM
atul published this revision for review.Feb 6 2023, 2:14 PM
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B16197: Diff 22161.Feb 6 2023, 2:26 PM
atul edited the summary of this revision. (Show Details)Feb 6 2023, 5:52 PM
atul added a parent revision: D6637: [web] Add ENSAvatar to `ConnectedWalletInfo` if set.
atul mentioned this in D6639: [lib] Move `ConnectedWalletInfo` from `web` -> `lib`.
atul added a child revision: D6639: [lib] Move `ConnectedWalletInfo` from `web` -> `lib`.
ashoat accepted this revision.Feb 6 2023, 5:56 PM

Didn't really review

This revision is now accepted and ready to land.Feb 6 2023, 5:56 PM
atul updated this revision to Diff 22200.Feb 7 2023, 9:01 AM

rebase + land

This revision was landed with ongoing or failed builds.Feb 7 2023, 9:02 AM
Closed by commit rCOMM8897f461be7b: [lib] Move `SWMansion.react` to `lib` so it can be shared across `web` and… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM8897f461be7b: [lib] Move `SWMansion.react` to `lib` so it can be shared across `web` and….
Harbormaster completed remote builds in B16231: Diff 22200.Feb 7 2023, 9:16 AM

Revision Contents
Changeset List

Diff 22201

View Options

lib/components/SWMansionIcon.react.js

Loading...
View Options

lib/package.json

Loading...
View Options

web/SWMansionIcon.react.js

Loading...
View Options

web/account/connected-wallet-info.react.js

Loading...
View Options

web/account/password-input.react.js

Loading...
View Options

web/account/siwe-login-form.react.js

Loading...
View Options

web/apps/app-listing.react.js

Loading...
View Options

web/calendar/calendar.react.js

Loading...
View Options

web/chat/chat-input-bar.react.js

Loading...
View Options

web/chat/chat-thread-ancestors.react.js

Loading...
View Options

web/chat/chat-thread-composer.react.js

Loading...
View Options

web/chat/chat-thread-list-item-menu.react.js

Loading...
View Options

web/chat/chat-thread-list-item.react.js

Loading...
View Options

web/chat/chat-thread-tab.react.js

Loading...
View Options

web/chat/thread-menu.react.js

Loading...
View Options

web/components/clear-search-button.react.js

Loading...
View Options

web/components/enum-settings-option-info.react.js

Loading...
View Options

web/components/label.react.js

Loading...
View Options

web/components/menu-item.react.js

Loading...
View Options

web/components/navigation-arrows.react.js

Loading...
View Options

web/components/search.react.js

Loading...
View Options

web/modals/modal.react.js

Loading...
View Options

web/modals/threads/create/steps/subchannel-settings.react.js

Loading...
View Options

web/modals/threads/members/member.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-delete-tab.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-privacy-tab.react.js

Loading...
View Options

web/modals/threads/subchannels/subchannel.react.js

Loading...
View Options

web/settings/account-delete-modal.react.js

Loading...
View Options

web/settings/account-settings.react.js

Loading...
View Options

web/settings/relationship/block-list-row.react.js

Loading...
View Options

web/settings/relationship/friend-list-row.react.js

Loading...
View Options

web/sidebar/app-switcher.react.js

Loading...
View Options

web/sidebar/community-picker.react.js

Loading...