Page MenuHomePhabricator
Differential D6639

[lib] Move `ConnectedWalletInfo` from `web` -> `lib`
ClosedPublic
Actions

Authored by atul on Feb 6 2023, 3:20 PM.
Tags
None
Referenced Files
F1780407: D6639.diff
Sat, May 18, 4:27 AM
Unknown Object (File)
Mon, May 13, 1:06 AM
Unknown Object (File)
Apr 17 2024, 5:29 AM
Unknown Object (File)
Apr 17 2024, 5:29 AM
Unknown Object (File)
Apr 17 2024, 5:28 AM
Unknown Object (File)
Apr 17 2024, 5:28 AM
Unknown Object (File)
Apr 17 2024, 5:20 AM
Unknown Object (File)
Apr 6 2024, 7:05 AM
View All 29 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM587103fd89d2: [lib] Move `ConnectedWalletInfo` from `web` -> `lib`
Summary

So it can be used across web and landing (for native SIWE).

Depends on D6638

Test Plan

Things continue to look as expected:

1e93ea.png (1×962 px, 136 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Feb 6 2023, 3:20 PM
atul published this revision for review.Feb 6 2023, 3:22 PM
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B16198: Diff 22162.Feb 6 2023, 3:35 PM
atul edited the summary of this revision. (Show Details)Feb 6 2023, 5:52 PM
atul added a child revision: D6640: [web] Flip the switch to enable SIWE on `web`.
atul edited the summary of this revision. (Show Details)
atul added a parent revision: D6638: [lib] Move `SWMansion.react` to `lib` so it can be shared across `web` and `landing`.
ashoat accepted this revision.Feb 6 2023, 5:57 PM

Didn't really review

This revision is now accepted and ready to land.Feb 6 2023, 5:57 PM
atul updated this revision to Diff 22202.Feb 7 2023, 9:04 AM

rebase + land

This revision was landed with ongoing or failed builds.Feb 7 2023, 9:05 AM
Closed by commit rCOMM587103fd89d2: [lib] Move `ConnectedWalletInfo` from `web` -> `lib` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM587103fd89d2: [lib] Move `ConnectedWalletInfo` from `web` -> `lib`.
Harbormaster completed remote builds in B16232: Diff 22202.Feb 7 2023, 9:18 AM

Revision Contents
Changeset List

Diff 22204

View Options

lib/components/connected-wallet-info.css

Loading...
View Options

lib/components/connected-wallet-info.react.js

Loading...
View Options

lib/package.json

Loading...
View Options

web/account/connected-wallet-info.css

Loading...
View Options

web/account/connected-wallet-info.react.js

Loading...
View Options

web/account/siwe-login-form.react.js

Loading...