issue: https://linear.app/comm/issue/ENG-2794/make-it-possible-to-display-only-chats-from-a-given-community-in-the
In D6457 I added architectural changes that allow for a new type of calendar filter. In this diff I add logic to the web reducer, that will handle setting this state.
This used to be diff D6458, but I messed up somethin in my local git, and can't get that commit back, sorry.
Details
Details
Dispatch updateCalendarCommunityFilter and clearCalendarCommunityFilter actions, check in redux tools that they succeed, and redux state changes as expected.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
MAke clearCalendarCommunityFilter action set communityFilter to null to make the code more logical
Comment Actions
I think the order of diffs in this stack is a little bit mixed, here you use filteredCommunityThreadIDs which is introduced in child revision, but overall looks good
| web/redux/redux-setup.js | ||
|---|---|---|
| 20 ↗ | (On Diff #22260) | can be merged with line 19 |
| 136 ↗ | (On Diff #22260) | can be shortened |
| 145 ↗ | (On Diff #22260) | Is the destruction needed? Can it be just calendarFilters: nonThreadFilters? |
Comment Actions
@inka encourage you to think critically about your Git workflow... I suspect you have multiple branches for a single stack or something like that. You should generally have one branch per stack and one local commit per diff
Comment Actions
@inka encourage you to think critically about your Git workflow... I suspect you have multiple branches for a single stack or something like that. You should generally have one branch per stack and one local commit per diff
What happened here is that these commits were in the order you just saw them in my diff stack, but due to changes in logic i had to change their order. And I simply forgot to change it in the diff stack as well, will fix that now.
I actually just have a one, straight branch in my local copy, and one commit per diff. What happened lately with the aborted diff was that I accidentally dropped it during a rebase, and git cherry-pick was failing for some reason. So I created a new one, because I didn't know about the other possibilities that @ashoat explained to me later. I'll do better next time :)