Differential D6740

[web] Restyle filters button
ClosedPublic
Actions

Authored by inka on Feb 15 2023, 5:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 25, 7:00 AM

	Unknown Object (File)
	Mon, Nov 25, 6:55 AM

	Unknown Object (File)
	Mon, Nov 25, 6:43 AM

	Unknown Object (File)
	Mon, Nov 25, 6:33 AM

	Unknown Object (File)
	Mon, Nov 25, 4:21 AM

	Unknown Object (File)
	Wed, Nov 20, 5:03 PM

	Unknown Object (File)
	Wed, Nov 20, 4:20 PM

	Unknown Object (File)
	Wed, Nov 20, 4:20 PM

Subscribers

Details

Reviewers

michal
kamil
• kuba

Commits

rCOMMdba2c6a28585: [web] Restyle filters button

Summary

Issue: https://linear.app/comm/issue/ENG-2964/restyle-the-filters-button
Restyling the filters button. Note that in the comments, it has been decided that we'll use a different icon than in the designs.
For now keeping the button after opening the filter panel. This will be changed in the future

Test Plan

Run web app, checked that the button displays correctly, and pressing it opens the filter panel

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Feb 15 2023, 5:22 AM

inka held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 15 2023, 5:22 AM

inka edited the summary of this revision. (Show Details)Feb 15 2023, 5:23 AM

Harbormaster completed remote builds in B16532: Diff 22617.Feb 15 2023, 5:37 AM

Add hover, change colours since the designs have changed

inka published this revision for review.Feb 16 2023, 1:06 AM

inka edited the summary of this revision. (Show Details)

inka edited the test plan for this revision. (Show Details)

inka attached a referenced file: F382519: Screen Recording 2023-02-16 at 10.04.48.mov. (Show Details)

Harbormaster completed remote builds in B16548: Diff 22644.Feb 16 2023, 1:18 AM

We might add a short transition to the hover state. Looks great!

This revision is now accepted and ready to land.Feb 16 2023, 5:32 AM

Rebase

Harbormaster failed remote builds in B16685: Diff 22818!Feb 21 2023, 3:21 AM

Rebase

Harbormaster completed remote builds in B16702: Diff 22855.Feb 21 2023, 7:31 AM

Closed by commit rCOMMdba2c6a28585: [web] Restyle filters button (authored by • InkaSokolowska). · Explain WhyMar 6 2023, 6:57 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMMdba2c6a28585: [web] Restyle filters button.

Revision Contents
Changeset List

Path

Size

web/

calendar/

28 lines

calendar.react.js

5 lines

3 lines

Diff 22644

web/calendar/calendar.css

Loading...

web/calendar/calendar.react.js

Loading...

web/theme.css

Loading...