Page MenuHomePhabricator
Differential D6746

[web] Add a selector for getting the item currently selected in the drawer
ClosedPublic
Actions

Authored by inka on Feb 16 2023, 6:52 AM.
Tags
None
Referenced Files
F3381803: D6746.diff
Thu, Nov 28, 6:24 AM
Unknown Object (File)
Sun, Nov 24, 3:48 PM
Unknown Object (File)
Sun, Nov 24, 3:48 PM
Unknown Object (File)
Thu, Nov 21, 3:21 PM
Unknown Object (File)
Wed, Nov 20, 4:21 PM
Unknown Object (File)
Wed, Nov 20, 4:21 PM
Unknown Object (File)
Tue, Nov 19, 10:01 AM
Unknown Object (File)
Tue, Nov 19, 10:01 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
michal
kamil
Commits
rCOMM9b215ace7eb8: [web] Add a selector for getting the item currently selected in the drawer
Summary

issue: https://linear.app/comm/issue/ENG-2740/add-navigation-state-info-to-the-top-bar
Adding a selector for getting the item currently selected in the drawer, taking into account that in different tabs this value is stored differently

Test Plan

Log to the console the value returned when being in different tabs, checked that it is correct.

Diff Detail

Repository
rCOMM Comm
Branch
inka/web_drawer_continuation
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Feb 16 2023, 6:52 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptFeb 16 2023, 6:52 AM
inka added a parent revision: D6745: [web] Split ThreadTopBar into two components.Feb 16 2023, 6:53 AM
Harbormaster completed remote builds in B16555: Diff 22651.Feb 16 2023, 7:07 AM
inka requested review of this revision.Feb 16 2023, 7:07 AM
tomek accepted this revision.Feb 17 2023, 12:42 AM
This revision is now accepted and ready to land.Feb 17 2023, 12:42 AM
inka updated this revision to Diff 22858.Feb 21 2023, 7:17 AM

Rebase

Harbormaster completed remote builds in B16705: Diff 22858.Feb 21 2023, 7:33 AM
inka added a child revision: D6841: [web] Add PossiblyEmptyNavStateInfoBar to handle collapse animation in the topbar when no community is selected.Feb 23 2023, 1:00 AM
Closed by commit rCOMM9b215ace7eb8: [web] Add a selector for getting the item currently selected in the drawer (authored by • InkaSokolowska). · Explain WhyMar 13 2023, 6:35 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMM9b215ace7eb8: [web] Add a selector for getting the item currently selected in the drawer.

Revision Contents
Changeset List

PathSize
web/
selectors/
13 lines

Diff 22651

View Options

web/selectors/thread-selectors.js

Loading...