[web] Split ThreadTopBar into two components
ClosedPublic
Actions

Authored by inka on Feb 16 2023, 6:34 AM.

Details

Reviewers

michal
• kuba
kamil

Commits

rCOMM24839908bd81: [web] Split ThreadTopBar into two components

Summary

Issue: https://linear.app/comm/issue/ENG-2740/add-navigation-state-info-to-the-top-bar
Navigation state info will be displayed in the Topbar component. It used to be in ChatMessageList container. Now, in ChatListContainer we will only display the name of the chat.
I split ThreadTopBar component into two: the one that will be displayed in the Tobbar, that includes the ThreadAncestors, but doesn't have the ThreadMenu, and a complementary component, that is used in the
ChatMessageListContainer. I will change the NavStateInfoBar further, accordinng to the designs, in the following diffs.
Some files were additionally moved to keep the code correctly divided into folders.

Test Plan

Run web app, checked that the header of ChatMessageListContainer displays only chat's: name, colour square and menu button. I also exchanged ThreadTopBar in ChatMessageListContainer for NavStateInfoBar and check that is displays correctly:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Feb 16 2023, 6:34 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 16 2023, 6:34 AM

inka edited the summary of this revision. (Show Details)Feb 16 2023, 6:35 AM

inka edited the test plan for this revision. (Show Details)Feb 16 2023, 6:37 AM

Fix props types names

Harbormaster completed remote builds in B16553: Diff 22649.Feb 16 2023, 6:51 AM

inka added a parent revision: D6741: [web] Move logic for fetching ThreadInfo for possibly pending chat out of ChatMessageListContainer component.Feb 16 2023, 6:53 AM

inka added a child revision: D6746: [web] Add a selector for getting the item currently selected in the drawer.

Harbormaster completed remote builds in B16554: Diff 22650.Feb 16 2023, 6:58 AM

inka requested review of this revision.Feb 16 2023, 6:58 AM

Rebase

Harbormaster failed remote builds in B16704: Diff 22857!Feb 21 2023, 7:32 AM

Harbormaster completed remote builds in B16704: Diff 22857.Feb 21 2023, 7:52 AM

inka added a child revision: D6841: [web] Add PossiblyEmptyNavStateInfoBar to handle collapse animation in the topbar when no community is selected.Feb 23 2023, 1:00 AM

inka removed a child revision: D6841: [web] Add PossiblyEmptyNavStateInfoBar to handle collapse animation in the topbar when no community is selected.

inka mentioned this in D6851: [web] Fix long names in displaying incorrectly in the ChatMessageListContainers header.Feb 23 2023, 6:19 AM

michal accepted this revision.Mar 2 2023, 2:29 AM

michal added inline comments.

web/navigation-panels/nav-state-info-bar.react.js
25–34 ↗	(On Diff #22857)	We don't use `threadMenu` here so could we simplify the `topBarContainer` and `topBarThreadInfo` divs and css classes into one?